Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-17 Thread Jiri Pirko
Wed, May 17, 2017 at 02:47:47PM CEST, j...@mojatatu.com wrote: >On 17-05-17 01:47 AM, Jiri Pirko wrote: >> Wed, May 17, 2017 at 12:38:08AM CEST, xiyou.wangc...@gmail.com wrote: > >[..] >> > >> > tcf_auto_major_prio()? >> >> That makes no sense. prio is passed from user in upper 2 bytes (god >> kn

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-17 Thread Jamal Hadi Salim
On 17-05-17 01:47 AM, Jiri Pirko wrote: Wed, May 17, 2017 at 12:38:08AM CEST, xiyou.wangc...@gmail.com wrote: [..] tcf_auto_major_prio()? That makes no sense. prio is passed from user in upper 2 bytes (god knows why but that is how it is). I am not sure it is any god's decision ;-> Unless

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Jiri Pirko
Wed, May 17, 2017 at 12:38:08AM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 2:03 PM, Jiri Pirko wrote: >> Tue, May 16, 2017 at 11:01:52PM CEST, xiyou.wangc...@gmail.com wrote: >>>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: From: Jiri Pirko Call the helpe

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 2:03 PM, Jiri Pirko wrote: > Tue, May 16, 2017 at 11:01:52PM CEST, xiyou.wangc...@gmail.com wrote: >>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Call the helper from the function rather than to always adjust the >>> return value of the

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 11:01:52PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Call the helper from the function rather than to always adjust the >> return value of the function. > >And rename the function name to reflect this

Re: [patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Call the helper from the function rather than to always adjust the > return value of the function. And rename the function name to reflect this change?

[patch net-next v3 05/10] net: sched: move TC_H_MAJ macro call into tcf_auto_prio

2017-05-16 Thread Jiri Pirko
From: Jiri Pirko Call the helper from the function rather than to always adjust the return value of the function. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 0e49e6e..7