Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-13 Thread Jakub Kicinski
On Mon, 12 Aug 2019 19:46:57 -0600, David Ahern wrote: > On 8/12/19 7:11 PM, Jakub Kicinski wrote: > > If the devlink instance just disappeared - that'd be a very very strange > > thing. Only software objects disappear with the namespace. > > Netdevices without ->rtnl_link_ops go back to init_net.

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread Jiri Pirko
Tue, Aug 13, 2019 at 02:24:41AM CEST, dsah...@gmail.com wrote: >On 8/12/19 7:47 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Devlink from the beginning counts with network namespaces, but the >> instances has been fixed to init_net. The first patch allows user >> to move existing devlink insta

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread Jiri Pirko
Tue, Aug 13, 2019 at 03:11:00AM CEST, jakub.kicin...@netronome.com wrote: >On Mon, 12 Aug 2019 18:24:41 -0600, David Ahern wrote: >> On 8/12/19 7:47 AM, Jiri Pirko wrote: >> > From: Jiri Pirko >> > >> > Devlink from the beginning counts with network namespaces, but the >> > instances has been fix

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread David Ahern
On 8/12/19 7:11 PM, Jakub Kicinski wrote: > If the devlink instance just disappeared - that'd be a very very strange > thing. Only software objects disappear with the namespace. > Netdevices without ->rtnl_link_ops go back to init_net. netdevsim still has rtnl_link_ops: static struct rtnl_link_o

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2019 18:24:41 -0600, David Ahern wrote: > On 8/12/19 7:47 AM, Jiri Pirko wrote: > > From: Jiri Pirko > > > > Devlink from the beginning counts with network namespaces, but the > > instances has been fixed to init_net. The first patch allows user > > to move existing devlink instanc

Re: [patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread David Ahern
On 8/12/19 7:47 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Devlink from the beginning counts with network namespaces, but the > instances has been fixed to init_net. The first patch allows user > to move existing devlink instances into namespaces: > > $ devlink dev > netdevsim/netdevsim1 > $ i

[patch net-next v3 0/3] net: devlink: Finish network namespace support

2019-08-12 Thread Jiri Pirko
From: Jiri Pirko Devlink from the beginning counts with network namespaces, but the instances has been fixed to init_net. The first patch allows user to move existing devlink instances into namespaces: $ devlink dev netdevsim/netdevsim1 $ ip netns add ns1 $ devlink dev set netdevsim/netdevsim1 n