Re: [patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications

2019-05-29 Thread Jiri Pirko
Wed, May 29, 2019 at 06:47:54PM CEST, jakub.kicin...@netronome.com wrote: >On Wed, 29 May 2019 10:00:16 +0200, Jiri Pirko wrote: >> Tue, May 28, 2019 at 10:01:15PM CEST, jakub.kicin...@netronome.com wrote: >> >On Tue, 28 May 2019 13:48:46 +0200, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >>

Re: [patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications

2019-05-29 Thread Jakub Kicinski
On Wed, 29 May 2019 10:00:16 +0200, Jiri Pirko wrote: > Tue, May 28, 2019 at 10:01:15PM CEST, jakub.kicin...@netronome.com wrote: > >On Tue, 28 May 2019 13:48:46 +0200, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Signed-off-by: Jiri Pirko > >> --- > >> v1->v2: > >> - added debugfs toggle

Re: [patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications

2019-05-29 Thread Jiri Pirko
Tue, May 28, 2019 at 10:01:15PM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 28 May 2019 13:48:46 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Signed-off-by: Jiri Pirko >> --- >> v1->v2: >> - added debugfs toggle to enable/disable flash status notifications > >Could you please add a

Re: [patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications

2019-05-28 Thread Jakub Kicinski
On Tue, 28 May 2019 13:48:46 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > --- > v1->v2: > - added debugfs toggle to enable/disable flash status notifications Could you please add a selftest making use of netdevsim code? Sorry, I must have liked the feature so muc

[patch net-next v2 7/7] netdevsim: implement fake flash updating with notifications

2019-05-28 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko --- v1->v2: - added debugfs toggle to enable/disable flash status notifications --- drivers/net/netdevsim/dev.c | 44 +++ drivers/net/netdevsim/netdevsim.h | 1 + 2 files changed, 45 insertions(+) diff --git a/driver