Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-27 Thread David Ahern
On 11/23/17 5:25 AM, Arkadi Sharshevsky wrote: > [...] > + > + resource = devlink_resource_find(devlink, NULL, resource_id); > + if (!resource) > + return -EINVAL; > + > + if (!resource->resource_ops->size_validate) > + return -EINVAL; genl_info

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-23 Thread Arkadi Sharshevsky
[...] + + resource = devlink_resource_find(devlink, NULL, resource_id); + if (!resource) + return -EINVAL; + + if (!resource->resource_ops->size_validate) + return -EINVAL; >>> >>> genl_info has extack; please add user messages for the above f

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-19 Thread David Ahern
On 11/19/17 1:17 AM, Arkadi Sharshevsky wrote: > > > On 11/18/2017 08:34 PM, David Ahern wrote: >> On 11/14/17 9:18 AM, Jiri Pirko wrote: >>> diff --git a/include/net/devlink.h b/include/net/devlink.h >>> index 4d2c6fc..960e80a 100644 >>> --- a/include/net/devlink.h >>> +++ b/include/net/devlink.

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-19 Thread Arkadi Sharshevsky
On 11/18/2017 08:34 PM, David Ahern wrote: > On 11/14/17 9:18 AM, Jiri Pirko wrote: >> diff --git a/include/net/devlink.h b/include/net/devlink.h >> index 4d2c6fc..960e80a 100644 >> --- a/include/net/devlink.h >> +++ b/include/net/devlink.h > ... > >> @@ -469,6 +523,32 @@ devlink_dpipe_match_put

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-18 Thread David Ahern
On 11/14/17 9:18 AM, Jiri Pirko wrote: > diff --git a/include/net/devlink.h b/include/net/devlink.h > index 4d2c6fc..960e80a 100644 > --- a/include/net/devlink.h > +++ b/include/net/devlink.h ... > @@ -469,6 +523,32 @@ devlink_dpipe_match_put(struct sk_buff *skb, > return 0; > } > > +stat

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-15 Thread Arkadi Sharshevsky
On 11/15/2017 09:59 AM, Jakub Kicinski wrote: > On Tue, 14 Nov 2017 17:18:43 +0100, Jiri Pirko wrote: >> From: Arkadi Sharshevsky >> >> Add support for hardware resource abstraction over devlink. Each resource >> is identified via id, furthermore it contains information regarding its >> size and

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-15 Thread Jakub Kicinski
On Tue, 14 Nov 2017 17:18:43 +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Add support for hardware resource abstraction over devlink. Each resource > is identified via id, furthermore it contains information regarding its > size and its related sub resources. Each resource can also pro

[patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

2017-11-14 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for hardware resource abstraction over devlink. Each resource is identified via id, furthermore it contains information regarding its size and its related sub resources. Each resource can also provide its current occupancy. In some cases the sizes of some res