Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread Hannes Frederic Sowa
On 17.11.2016 19:32, Ido Schimmel wrote: > On Thu, Nov 17, 2016 at 06:20:39PM +0100, Hannes Frederic Sowa wrote: >> On 17.11.2016 17:45, David Miller wrote: >>> From: Hannes Frederic Sowa >>> Date: Thu, 17 Nov 2016 15:36:48 +0100 >>> The other way is the journal idea I had, which uses an rb-t

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread Hannes Frederic Sowa
On 17.11.2016 19:16, David Miller wrote: > From: Hannes Frederic Sowa > Date: Thu, 17 Nov 2016 18:20:39 +0100 > >> Hi, >> >> On 17.11.2016 17:45, David Miller wrote: >>> From: Hannes Frederic Sowa >>> Date: Thu, 17 Nov 2016 15:36:48 +0100 >>> The other way is the journal idea I had, which u

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread Ido Schimmel
On Thu, Nov 17, 2016 at 06:20:39PM +0100, Hannes Frederic Sowa wrote: > On 17.11.2016 17:45, David Miller wrote: > > From: Hannes Frederic Sowa > > Date: Thu, 17 Nov 2016 15:36:48 +0100 > > > >> The other way is the journal idea I had, which uses an rb-tree with > >> timestamps as keys (can be la

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread David Miller
From: Hannes Frederic Sowa Date: Thu, 17 Nov 2016 18:20:39 +0100 > Hi, > > On 17.11.2016 17:45, David Miller wrote: >> From: Hannes Frederic Sowa >> Date: Thu, 17 Nov 2016 15:36:48 +0100 >> >>> The other way is the journal idea I had, which uses an rb-tree with >>> timestamps as keys (can be l

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread Hannes Frederic Sowa
Hi, On 17.11.2016 17:45, David Miller wrote: > From: Hannes Frederic Sowa > Date: Thu, 17 Nov 2016 15:36:48 +0100 > >> The other way is the journal idea I had, which uses an rb-tree with >> timestamps as keys (can be lamport timestamps). You insert into the tree >> until the dump is finished and

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread Hannes Frederic Sowa
On 17.11.2016 14:10, Ido Schimmel wrote: > Hi Hannes, > > On Wed, Nov 16, 2016 at 08:43:25PM +0100, Hannes Frederic Sowa wrote: >> On 16.11.2016 19:51, Ido Schimmel wrote: >>> On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: On 16.11.2016 16:18, Ido Schimmel wrote: >

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread Ido Schimmel
Hi Hannes, On Wed, Nov 16, 2016 at 08:43:25PM +0100, Hannes Frederic Sowa wrote: > On 16.11.2016 19:51, Ido Schimmel wrote: > > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: > >> On 16.11.2016 16:18, Ido Schimmel wrote: > >>> On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-17 Thread David Miller
From: Hannes Frederic Sowa Date: Thu, 17 Nov 2016 15:36:48 +0100 > The other way is the journal idea I had, which uses an rb-tree with > timestamps as keys (can be lamport timestamps). You insert into the tree > until the dump is finished and use it as queue later to shuffle stuff > into the hard

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Ido Schimmel
On Wed, Nov 16, 2016 at 08:43:25PM +0100, Hannes Frederic Sowa wrote: > On 16.11.2016 19:51, Ido Schimmel wrote: > > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: > >> On 16.11.2016 16:18, Ido Schimmel wrote: > >>> On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic So

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Hannes Frederic Sowa
On 16.11.2016 19:51, Ido Schimmel wrote: > Hi, > > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: >> On 16.11.2016 16:18, Ido Schimmel wrote: >>> On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote: On 16.11.2016 15:09, Jiri Pirko wrote: > From: Ido

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Ido Schimmel
Hi, On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: > On 16.11.2016 16:18, Ido Schimmel wrote: > > On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote: > >> On 16.11.2016 15:09, Jiri Pirko wrote: > >>> From: Ido Schimmel > >>> > >>> Commit b90eb7549499 ("fib

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Hannes Frederic Sowa
On 16.11.2016 16:18, Ido Schimmel wrote: > Hi Hannes, > > On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote: >> On 16.11.2016 15:09, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") >>> introduced a new noti

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Hannes Frederic Sowa
On 16.11.2016 17:27, David Miller wrote: > From: Hannes Frederic Sowa > Date: Wed, 16 Nov 2016 15:51:01 +0100 > >> I don't see a way around doing a journal like in filesystems somehow, > > We really just need a sequence counter incremented for each insert/remove, > and restart the dump from the

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Ido Schimmel
Hi Dave, On Wed, Nov 16, 2016 at 11:27:35AM -0500, David Miller wrote: > From: Hannes Frederic Sowa > Date: Wed, 16 Nov 2016 15:51:01 +0100 > > > I don't see a way around doing a journal like in filesystems somehow, > > We really just need a sequence counter incremented for each insert/remove,

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 16 Nov 2016 15:51:01 +0100 > I don't see a way around doing a journal like in filesystems somehow, We really just need a sequence counter incremented for each insert/remove, and restart the dump from the beginning if it changes mid-dump.

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Ido Schimmel
Hi Hannes, On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote: > On 16.11.2016 15:09, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") > > introduced a new notification chain to notify listeners (f.e., switc

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Hannes Frederic Sowa
On 16.11.2016 15:09, Jiri Pirko wrote: > From: Ido Schimmel > > Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") > introduced a new notification chain to notify listeners (f.e., switchdev > drivers) about addition and deletion of routes. > > However, upon registration to th

[patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Jiri Pirko
From: Ido Schimmel Commit b90eb7549499 ("fib: introduce FIB notification infrastructure") introduced a new notification chain to notify listeners (f.e., switchdev drivers) about addition and deletion of routes. However, upon registration to the chain the FIB tables can already be populated, whic