Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 06:31:39PM CET, step...@networkplumber.org wrote: >On Tue, 23 Feb 2016 12:26:00 +0100 >Hannes Frederic Sowa wrote: > >> Hi Jiri, >> >> On 22.02.2016 19:31, Jiri Pirko wrote: >> > From: Jiri Pirko >> > >> > So far, there has been an mlx4-specific sysfs file allowing user to >

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread David Miller
From: Jiri Pirko Date: Tue, 23 Feb 2016 13:21:10 +0100 > Sysfs is not the place to do this things. +1 > It was already discussed here multiple times. There was and attempt > to use configfs, which was also refused. Netlink is the only place > to go. For multiple reasons, including well defined

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Stephen Hemminger
On Tue, 23 Feb 2016 12:26:00 +0100 Hannes Frederic Sowa wrote: > Hi Jiri, > > On 22.02.2016 19:31, Jiri Pirko wrote: > > From: Jiri Pirko > > > > So far, there has been an mlx4-specific sysfs file allowing user to > > change port type to either Ethernet of InfiniBand. This is very > > inconveni

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Hannes Frederic Sowa
On 23.02.2016 17:55, Jiri Pirko wrote: Tue, Feb 23, 2016 at 05:45:07PM CET, han...@stressinduktion.org wrote: On 23.02.2016 17:04, Jiri Pirko wrote: Tue, Feb 23, 2016 at 04:57:17PM CET, han...@stressinduktion.org wrote: On 23.02.2016 16:30, Jiri Pirko wrote: Tue, Feb 23, 2016 at 04:16:11PM CE

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 05:45:07PM CET, han...@stressinduktion.org wrote: >On 23.02.2016 17:04, Jiri Pirko wrote: >>Tue, Feb 23, 2016 at 04:57:17PM CET, han...@stressinduktion.org wrote: >>>On 23.02.2016 16:30, Jiri Pirko wrote: Tue, Feb 23, 2016 at 04:16:11PM CET, han...@stressinduktion.org wrote

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Hannes Frederic Sowa
On 23.02.2016 17:04, Jiri Pirko wrote: Tue, Feb 23, 2016 at 04:57:17PM CET, han...@stressinduktion.org wrote: On 23.02.2016 16:30, Jiri Pirko wrote: Tue, Feb 23, 2016 at 04:16:11PM CET, han...@stressinduktion.org wrote: 1) is easily solvable, just drop the ifindex style attributes and alway

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 04:57:17PM CET, han...@stressinduktion.org wrote: >On 23.02.2016 16:30, Jiri Pirko wrote: >>Tue, Feb 23, 2016 at 04:16:11PM CET, han...@stressinduktion.org wrote: >> >> >> >1) is easily solvable, just drop the ifindex style attributes and always >force the user to enter

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Hannes Frederic Sowa
On 23.02.2016 16:30, Jiri Pirko wrote: Tue, Feb 23, 2016 at 04:16:11PM CET, han...@stressinduktion.org wrote: 1) is easily solvable, just drop the ifindex style attributes and always force the user to enter the bus and bus-topology id. But why? Use can easily get that info and map it to dev

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 04:16:11PM CET, han...@stressinduktion.org wrote: >>>1) is easily solvable, just drop the ifindex style attributes and always >>>force the user to enter the bus and bus-topology id. >> >>But why? Use can easily get that info and map it to devlink index. It >>aligns with nl80

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 04:20:09PM CET, go...@cumulusnetworks.com wrote: >> > >> >I am not sure, but one of the initial problems was that this information >> >should already be there before the driver actually gets loaded, no? These >> >changes don't solve this problem either? >> >> This is planne

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Andy Gospodarek
On Tue, Feb 23, 2016 at 03:26:27PM +0100, Jiri Pirko wrote: > Tue, Feb 23, 2016 at 02:28:05PM CET, han...@stressinduktion.org wrote: > >On 23.02.2016 13:21, Jiri Pirko wrote: > >>Tue, Feb 23, 2016 at 12:26:00PM CET, han...@stressinduktion.org wrote: > >>>Hi Jiri, > >>> > >>>On 22.02.2016 19:31, Jir

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Hannes Frederic Sowa
On 23.02.2016 15:26, Jiri Pirko wrote: Tue, Feb 23, 2016 at 02:28:05PM CET, han...@stressinduktion.org wrote: On 23.02.2016 13:21, Jiri Pirko wrote: Tue, Feb 23, 2016 at 12:26:00PM CET, han...@stressinduktion.org wrote: Hi Jiri, On 22.02.2016 19:31, Jiri Pirko wrote: From: Jiri Pirko So fa

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 02:28:05PM CET, han...@stressinduktion.org wrote: >On 23.02.2016 13:21, Jiri Pirko wrote: >>Tue, Feb 23, 2016 at 12:26:00PM CET, han...@stressinduktion.org wrote: >>>Hi Jiri, >>> >>>On 22.02.2016 19:31, Jiri Pirko wrote: From: Jiri Pirko So far, there has been an

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Hannes Frederic Sowa
On 23.02.2016 13:21, Jiri Pirko wrote: Tue, Feb 23, 2016 at 12:26:00PM CET, han...@stressinduktion.org wrote: Hi Jiri, On 22.02.2016 19:31, Jiri Pirko wrote: From: Jiri Pirko So far, there has been an mlx4-specific sysfs file allowing user to change port type to either Ethernet of InfiniBand

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Jiri Pirko
Tue, Feb 23, 2016 at 12:26:00PM CET, han...@stressinduktion.org wrote: >Hi Jiri, > >On 22.02.2016 19:31, Jiri Pirko wrote: >>From: Jiri Pirko >> >>So far, there has been an mlx4-specific sysfs file allowing user to >>change port type to either Ethernet of InfiniBand. This is very >>inconvenient. >

Re: [patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-23 Thread Hannes Frederic Sowa
Hi Jiri, On 22.02.2016 19:31, Jiri Pirko wrote: From: Jiri Pirko So far, there has been an mlx4-specific sysfs file allowing user to change port type to either Ethernet of InfiniBand. This is very inconvenient. Again, I want to express my concerns regarding all of this until this will be in

[patch net-next 3/9] mlx4: Implement port type setting via devlink interface

2016-02-22 Thread Jiri Pirko
From: Jiri Pirko So far, there has been an mlx4-specific sysfs file allowing user to change port type to either Ethernet of InfiniBand. This is very inconvenient. Allow to expose the same ability to set port type in a generic way using devlink interface. Signed-off-by: Jiri Pirko --- drivers/