Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-17 Thread Roopa Prabhu
On 5/17/16, 1:41 AM, Jiri Pirko wrote: > Tue, May 17, 2016 at 10:39:08AM CEST, tg...@suug.ch wrote: >> On 05/12/16 at 01:48pm, Jiri Pirko wrote: >>> diff --git a/net/core/dev.c b/net/core/dev.c >>> index 12436d1..a69e418 100644 >>> --- a/net/core/dev.c >>> +++ b/net/core/dev.c >>> @@ -7376,6 +7376,

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-17 Thread Jiri Pirko
Tue, May 17, 2016 at 10:39:08AM CEST, tg...@suug.ch wrote: >On 05/12/16 at 01:48pm, Jiri Pirko wrote: >> diff --git a/net/core/dev.c b/net/core/dev.c >> index 12436d1..a69e418 100644 >> --- a/net/core/dev.c >> +++ b/net/core/dev.c >> @@ -7376,6 +7376,8 @@ EXPORT_SYMBOL(netdev_stats_to_stats64); >>

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-17 Thread Thomas Graf
On 05/12/16 at 01:48pm, Jiri Pirko wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index 12436d1..a69e418 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -7376,6 +7376,8 @@ EXPORT_SYMBOL(netdev_stats_to_stats64); > * The device driver may provide its own method by setting >

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-16 Thread Jiri Pirko
Sun, May 15, 2016 at 05:44:11PM CEST, and...@lunn.ch wrote: >> I think we don/t understand each other. HW stats always include SW >> stats. Because whatever goes in or out goes through HW. > >Hi Jiri > >Bit of a corner case, but what about multicast and broadcast? Can you >do the replication in the

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-15 Thread Andrew Lunn
> I think we don/t understand each other. HW stats always include SW > stats. Because whatever goes in or out goes through HW. Hi Jiri Bit of a corner case, but what about multicast and broadcast? Can you do the replication in the switch, so that only a single copy is sent from the host to the sw

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-14 Thread Jiri Pirko
Sun, May 15, 2016 at 06:11:20AM CEST, ro...@cumulusnetworks.com wrote: >On 5/14/16, 11:46 AM, Jiri Pirko wrote: >> Sat, May 14, 2016 at 05:47:41PM CEST, ro...@cumulusnetworks.com wrote: >>> On 5/14/16, 5:49 AM, Jiri Pirko wrote: Fri, May 13, 2016 at 08:47:48PM CEST, ro...@cumulusnetworks.com w

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-14 Thread Roopa Prabhu
On 5/14/16, 11:46 AM, Jiri Pirko wrote: > Sat, May 14, 2016 at 05:47:41PM CEST, ro...@cumulusnetworks.com wrote: >> On 5/14/16, 5:49 AM, Jiri Pirko wrote: >>> Fri, May 13, 2016 at 08:47:48PM CEST, ro...@cumulusnetworks.com wrote: [snip] Jiri Pirko --- >> To me netdev stats

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-14 Thread Jiri Pirko
Sat, May 14, 2016 at 05:47:41PM CEST, ro...@cumulusnetworks.com wrote: >On 5/14/16, 5:49 AM, Jiri Pirko wrote: >> Fri, May 13, 2016 at 08:47:48PM CEST, ro...@cumulusnetworks.com wrote: >>> On 5/12/16, 11:03 PM, Jiri Pirko wrote: Thu, May 12, 2016 at 11:10:08PM CEST, ro...@cumulusnetworks.com w

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-14 Thread Roopa Prabhu
On 5/14/16, 5:49 AM, Jiri Pirko wrote: > Fri, May 13, 2016 at 08:47:48PM CEST, ro...@cumulusnetworks.com wrote: >> On 5/12/16, 11:03 PM, Jiri Pirko wrote: >>> Thu, May 12, 2016 at 11:10:08PM CEST, ro...@cumulusnetworks.com wrote: On 5/12/16, 4:48 AM, Jiri Pirko wrote: > From: Nogah Frankel

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-14 Thread Jiri Pirko
Fri, May 13, 2016 at 08:47:48PM CEST, ro...@cumulusnetworks.com wrote: >On 5/12/16, 11:03 PM, Jiri Pirko wrote: >> Thu, May 12, 2016 at 11:10:08PM CEST, ro...@cumulusnetworks.com wrote: >>> On 5/12/16, 4:48 AM, Jiri Pirko wrote: From: Nogah Frankel Till now we had a ndo statistics f

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-13 Thread Roopa Prabhu
On 5/12/16, 11:03 PM, Jiri Pirko wrote: > Thu, May 12, 2016 at 11:10:08PM CEST, ro...@cumulusnetworks.com wrote: >> On 5/12/16, 4:48 AM, Jiri Pirko wrote: >>> From: Nogah Frankel >>> >>> Till now we had a ndo statistics function that returned SW statistics. >>> We want to change the "basic" statis

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-12 Thread Jiri Pirko
Fri, May 13, 2016 at 12:23:13AM CEST, f.faine...@gmail.com wrote: >2016-05-12 14:10 GMT-07:00 Roopa Prabhu : >> On 5/12/16, 4:48 AM, Jiri Pirko wrote: >>> From: Nogah Frankel >>> >>> Till now we had a ndo statistics function that returned SW statistics. >>> We want to change the "basic" statistics

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-12 Thread Jiri Pirko
Thu, May 12, 2016 at 11:10:08PM CEST, ro...@cumulusnetworks.com wrote: >On 5/12/16, 4:48 AM, Jiri Pirko wrote: >> From: Nogah Frankel >> >> Till now we had a ndo statistics function that returned SW statistics. >> We want to change the "basic" statistics to return HW statistics if >> available. >>

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-12 Thread Florian Fainelli
2016-05-12 14:10 GMT-07:00 Roopa Prabhu : > On 5/12/16, 4:48 AM, Jiri Pirko wrote: >> From: Nogah Frankel >> >> Till now we had a ndo statistics function that returned SW statistics. >> We want to change the "basic" statistics to return HW statistics if >> available. >> In this case we need to exp

Re: [patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-12 Thread Roopa Prabhu
On 5/12/16, 4:48 AM, Jiri Pirko wrote: > From: Nogah Frankel > > Till now we had a ndo statistics function that returned SW statistics. > We want to change the "basic" statistics to return HW statistics if > available. > In this case we need to expose a new ndo to return the SW statistics. > Add a

[patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-12 Thread Jiri Pirko
From: Nogah Frankel Till now we had a ndo statistics function that returned SW statistics. We want to change the "basic" statistics to return HW statistics if available. In this case we need to expose a new ndo to return the SW statistics. Add a new ndo declaration to get SW statistics Add a func

[patch net-next 1/4] netdevice: add SW statistics ndo

2016-05-12 Thread Jiri Pirko
From: Nogah Frankel Till now we had a ndo statistics function that returned SW statistics. We want to change the "basic" statistics to return HW statistics if available. In this case we need to expose a new ndo to return the SW statistics. Add a new ndo declaration to get SW statistics Add a func