Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Jiri Pirko
Mon, Oct 05, 2015 at 07:43:23PM CEST, john.fastab...@gmail.com wrote: >On 15-10-05 10:24 AM, Jiri Pirko wrote: >> Mon, Oct 05, 2015 at 07:07:30PM CEST, john.fastab...@gmail.com wrote: >> >> >> Again, to make this clear, worlds are not just a rehash of tables. >>> >>> what are they

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread John Fastabend
On 15-10-05 10:24 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015 at 07:07:30PM CEST, john.fastab...@gmail.com wrote: > > > >>> >>> Again, to make this clear, worlds are not just a rehash of tables. >>> >> >> what are they then? Lets model those bits and let users configure them >> at runtime. >> >> S

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Jiri Pirko
Mon, Oct 05, 2015 at 07:07:30PM CEST, john.fastab...@gmail.com wrote: >> >> Again, to make this clear, worlds are not just a rehash of tables. >> > >what are they then? Lets model those bits and let users configure them >at runtime. > >So far I've had really good results modelling hardware as

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Jiri Pirko
Mon, Oct 05, 2015 at 07:00:06PM CEST, sfel...@gmail.com wrote: >On Mon, Oct 5, 2015 at 9:50 AM, Jiri Pirko wrote: >> Mon, Oct 05, 2015 at 06:37:20PM CEST, sfel...@gmail.com wrote: >>>On Mon, Oct 5, 2015 at 8:53 AM, Jiri Pirko wrote: Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wro

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread John Fastabend
[...] >>> Does this mean there is going to be a "ip link set dev DEV type rocker >>> mode MODE" command option? >>> >>> It doesn't seem right to be adding driver-specific IFLA_'s here. I >>> think this sets bad precedence for other drivers to add their own >>> knobs without thinking about a gener

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Scott Feldman
On Mon, Oct 5, 2015 at 9:50 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015 at 06:37:20PM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 5, 2015 at 8:53 AM, Jiri Pirko wrote: >>> Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wrote: On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: > Fr

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Jiri Pirko
Mon, Oct 05, 2015 at 06:37:20PM CEST, sfel...@gmail.com wrote: >On Mon, Oct 5, 2015 at 8:53 AM, Jiri Pirko wrote: >> Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wrote: >>>On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: From: Jiri Pirko Introduce a stub for allowing u

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Jiri Pirko
Mon, Oct 05, 2015 at 05:52:48PM CEST, john.fastab...@gmail.com wrote: >On 15-10-05 08:41 AM, Scott Feldman wrote: >> On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Introduce a stub for allowing user to change rocker port world/mode. >>> This is implemented using rt

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Scott Feldman
On Mon, Oct 5, 2015 at 8:53 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wrote: >>On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Introduce a stub for allowing user to change rocker port world/mode. >>> This is implemented using r

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread John Fastabend
On 15-10-05 08:41 AM, Scott Feldman wrote: > On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce a stub for allowing user to change rocker port world/mode. >> This is implemented using rtnl changelink op. >> >> Signed-off-by: Jiri Pirko > > [cut] > >> diff --g

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Jiri Pirko
Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wrote: >On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce a stub for allowing user to change rocker port world/mode. >> This is implemented using rtnl changelink op. >> >> Signed-off-by: Jiri Pirko > >[cu

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-05 Thread Scott Feldman
On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Introduce a stub for allowing user to change rocker port world/mode. > This is implemented using rtnl changelink op. > > Signed-off-by: Jiri Pirko [cut] > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_

[patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Introduce a stub for allowing user to change rocker port world/mode. This is implemented using rtnl changelink op. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 56 +++ include/uapi/linux/if_link.h | 11 +