Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-23 Thread Andrew Lunn
> > So when i look at these patches, i try to make sure the general use > > cases works, not just the plain boring Ethernet switch box use cases > > :-) > > So when doing it, we did think about multi-ASIC situations, so I think it > should > fit :) Maybe, maybe not. DSA is multi switch. That is

Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-23 Thread Yotam Gigi
On 09/22/2017 04:21 PM, Andrew Lunn wrote: > On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote: >> On 09/21/2017 06:26 PM, Andrew Lunn wrote: +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp, + struct mlxsw_sp_mr_route *mr_

Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-22 Thread Andrew Lunn
On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote: > On 09/21/2017 06:26 PM, Andrew Lunn wrote: > >> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp, > >> + struct mlxsw_sp_mr_route *mr_route) > >> +{ > >> + struct mlxsw_sp_mr *mr

Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-22 Thread Yotam Gigi
On 09/21/2017 06:26 PM, Andrew Lunn wrote: >> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp, >> + struct mlxsw_sp_mr_route *mr_route) >> +{ >> +struct mlxsw_sp_mr *mr = mlxsw_sp->mr; >> +u64 packets, bytes; >> + >> +if (mr_ro

Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-21 Thread Andrew Lunn
> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp, > +struct mlxsw_sp_mr_route *mr_route) > +{ > + struct mlxsw_sp_mr *mr = mlxsw_sp->mr; > + u64 packets, bytes; > + > + if (mr_route->route_action == MLXSW_SP_MR_ROUTE_ACTION_

[patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

2017-09-20 Thread Jiri Pirko
From: Yotam Gigi Add the multicast router offloading logic, which is in charge of handling the VIF and MFC notifications and translating it to the hardware logic API. The offloading logic has to overcome several obstacles in order to safely comply with the kernel multicast router user API: - It