Re: [patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-03 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 02 Nov 2016 15:36:30 +0300 > Hi! Here are a few fixes for raw-diag sockets handling: missing > sock_put call and jump for exiting from nested cycle. I made > patches for iproute2 as well so will send them out soon. Series applied, thanks.

Re: [patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-02 Thread Cyrill Gorcunov
On Wed, Nov 02, 2016 at 09:36:55AM -0600, David Ahern wrote: > > Limited to raw sockets or are you looking at multiple spec options (dev, > address, port)? > > I have not seen issues with tcp or udp. Running: > > ss -aK 'dev == red' > > drops all sockets bound to device 'red' (or at least

Re: [patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-02 Thread David Ahern
On 11/2/16 9:29 AM, Cyrill Gorcunov wrote: > On Wed, Nov 02, 2016 at 09:10:32AM -0600, David Ahern wrote: >>> @__dif != 0 the match may return socket where sk_bound_dev_if = 0 >>> instead of completely matching one. Isn't it? >> >> yes. I recently added an exact_dif to the lookup for listener socke

Re: [patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-02 Thread Cyrill Gorcunov
On Wed, Nov 02, 2016 at 09:10:32AM -0600, David Ahern wrote: > > @__dif != 0 the match may return socket where sk_bound_dev_if = 0 > > instead of completely matching one. Isn't it? > > yes. I recently added an exact_dif to the lookup for listener sockets > (see compute_score). Something like that

Re: [patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-02 Thread David Ahern
On 11/2/16 6:36 AM, Cyrill Gorcunov wrote: > Also I have a question about sockets lookup not for raw diag only > (though I didn't modify lookup procedure) but in general: the structure > inet_diag_req_v2 has inet_diag_sockid::idiag_if member which supposed to > carry interface index from userspace

[patch net-next 0/2] Fixes for raw diag sockets handling

2016-11-02 Thread Cyrill Gorcunov
Hi! Here are a few fixes for raw-diag sockets handling: missing sock_put call and jump for exiting from nested cycle. I made patches for iproute2 as well so will send them out soon. Also I have a question about sockets lookup not for raw diag only (though I didn't modify lookup procedure) but in g