Re: [patch net-next] stmmac: indent an if statement

2017-01-17 Thread Julia Lawall
On Tue, 17 Jan 2017, Alexandre Torgue wrote: > Hi Julia > > On 01/16/2017 11:10 PM, Julia Lawall wrote: > > > > > > On Tue, 17 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Mon, 16 Jan 2017, Dan Carpenter wrote:

Re: [patch net-next] stmmac: indent an if statement

2017-01-17 Thread Alexandre Torgue
Hi Julia On 01/16/2017 11:10 PM, Julia Lawall wrote: On Tue, 17 Jan 2017, Dan Carpenter wrote: On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: On Mon, 16 Jan 2017, Dan Carpenter wrote: On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: On Sun, Jan 15, 2017 at

Re: [patch net-next] stmmac: indent an if statement

2017-01-17 Thread Alexandre Torgue
Dear David On 01/16/2017 11:00 PM, David Miller wrote: From: Dan Carpenter Date: Tue, 17 Jan 2017 00:56:15 +0300 (It would be better if one of the stmmac people were responding here insead of a random fix the indenting weenie like myself.) They are all too busy trying to rename the driver,

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Julia Lawall
On Tue, 17 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > > > On Mon, 16 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread David Miller
From: Dan Carpenter Date: Tue, 17 Jan 2017 00:56:15 +0300 > (It would be better if one of the stmmac people were responding here > insead of a random fix the indenting weenie like myself.) They are all too busy trying to rename the driver, because that's so much more important.

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Dan Carpenter
On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > On Mon, 16 Jan 2017, Dan Carpenter wrote: > > > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > > > From: Dan Carpenter > > > > Date: Thu, 1

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Julia Lawall
On Mon, 16 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > > From: Dan Carpenter > > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > > > The break statement should be indented

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Dan Carpenter
On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > From: Dan Carpenter > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > The break statement should be indented one more tab. > > > > > > Signed-off-by: Dan Carpenter

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Dan Carpenter
On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > From: Dan Carpenter > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > The break statement should be indented one more tab. > > > > Signed-off-by: Dan Carpenter > > Applied, but like Julia I think we might have a missing of_node_put()

Re: [patch net-next] stmmac: indent an if statement

2017-01-15 Thread David Miller
From: Dan Carpenter Date: Thu, 12 Jan 2017 21:46:32 +0300 > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter Applied, but like Julia I think we might have a missing of_node_put() here.

Re: [patch net-next] stmmac: indent an if statement

2017-01-12 Thread Julia Lawall
On Thu, 12 Jan 2017, Dan Carpenter wrote: > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index ac32f9e..4daa8a3 100644 > -

[patch net-next] stmmac: indent an if statement

2017-01-12 Thread Dan Carpenter
The break statement should be indented one more tab. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index ac32f9e..4daa8a3 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c