Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-27 Thread Jiri Pirko
Fri, Jul 26, 2019 at 09:47:07PM CEST, step...@networkplumber.org wrote: >On Tue, 23 Jul 2019 13:25:37 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> One cannot depend on *argv being null in case of no arg is left on the >> command line. For example in batch mode, this is not always true. C

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-26 Thread Stephen Hemminger
On Tue, 23 Jul 2019 13:25:37 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > One cannot depend on *argv being null in case of no arg is left on the > command line. For example in batch mode, this is not always true. Check > argc instead to prevent crash. > > Reported-by: Alex Kushnarov > Fixes

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-26 Thread Stephen Hemminger
On Tue, 23 Jul 2019 21:36:00 +0200 Jiri Pirko wrote: > Tue, Jul 23, 2019 at 07:54:01PM CEST, step...@networkplumber.org wrote: > >On Tue, 23 Jul 2019 13:25:37 +0200 > >Jiri Pirko wrote: > > > >> From: Jiri Pirko > >> > >> One cannot depend on *argv being null in case of no arg is left on the

RE: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-24 Thread David Laight
From: Stephen Hemminger > Sent: 23 July 2019 18:54 > > On Tue, 23 Jul 2019 13:25:37 +0200 > Jiri Pirko wrote: > > > From: Jiri Pirko > > > > One cannot depend on *argv being null in case of no arg is left on the > > command line. For example in batch mode, this is not always true. Check > > arg

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-23 Thread Jiri Pirko
Tue, Jul 23, 2019 at 07:54:01PM CEST, step...@networkplumber.org wrote: >On Tue, 23 Jul 2019 13:25:37 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> One cannot depend on *argv being null in case of no arg is left on the >> command line. For example in batch mode, this is not always true. C

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-23 Thread Stephen Hemminger
On Tue, 23 Jul 2019 13:25:37 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > One cannot depend on *argv being null in case of no arg is left on the > command line. For example in batch mode, this is not always true. Check > argc instead to prevent crash. > > Reported-by: Alex Kushnarov > Fixes

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-23 Thread Stephen Hemminger
On Tue, 23 Jul 2019 13:25:37 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > One cannot depend on *argv being null in case of no arg is left on the > command line. For example in batch mode, this is not always true. Check > argc instead to prevent crash. > > Reported-by: Alex Kushnarov > Fixes

[patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-23 Thread Jiri Pirko
From: Jiri Pirko One cannot depend on *argv being null in case of no arg is left on the command line. For example in batch mode, this is not always true. Check argc instead to prevent crash. Reported-by: Alex Kushnarov Fixes: fd8b3d2c1b9b ("actions: Add support for user cookies") Signed-off-by: