Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2008-01-12 Thread Jeff Garzik
applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-31 Thread Dhananjay Phadke
Here's the reworked patch. This cleans up some unnecessary byte-swapping while setting up tx and interpreting rx desc. The 64 bit rx status data should be converted to host endian format only once and the macros just need to extract bitfields. This saves a spate of interrupts on pseries blades ca

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread Al Viro
On Wed, Dec 26, 2007 at 03:29:22PM -0800, Dhananjay Phadke wrote: > I agree for tx desc, the compiler would optimize. > > But for rx (status) desc, I didn't like multiple le64_to_cpu() > for extracting various fields out of same status dword. Fair enough; AFAICS, on rx side you don't mess with c

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread Dhananjay Phadke
I agree for tx desc, the compiler would optimize. But for rx (status) desc, I didn't like multiple le64_to_cpu() for extracting various fields out of same status dword. -Dhananjay On Wed, 26 Dec 2007, Al Viro wrote: > On Wed, Dec 26, 2007 at 10:23:59AM -0800, [EMAIL PROTECTED] wrote: > > This

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread Al Viro
On Wed, Dec 26, 2007 at 10:23:59AM -0800, [EMAIL PROTECTED] wrote: > This cleans up some unnecessary byte-swapping while setting up tx and > interpreting rx desc. The 64 bit rx status data should be converted > to host endian format only once and the macros just need to extract > bitfields. > -

[patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread dhananjay
This cleans up some unnecessary byte-swapping while setting up tx and interpreting rx desc. The 64 bit rx status data should be converted to host endian format only once and the macros just need to extract bitfields. This saves a spate of interrupts on pseries blades caused by buggy (non) process