Re: [patch 4/5] spidernet: fix HW structures for 64 bit dma_addr_t

2005-12-21 Thread Arnd Bergmann
Jeff Garzik wrote: > Assumptions or not, we have a standard way of documenting these > assumptions in the source code... __be32 and cpu_to_be32() do the right > thing (become no-ops) on BE, while ensuring that we can continue to use > valuable source checking tools. If the Cell drivers ever n

Re: [patch 4/5] spidernet: fix HW structures for 64 bit dma_addr_t

2005-12-20 Thread Jeff Garzik
Jens Osterkamp wrote: Christoph Hellwig <[EMAIL PROTECTED]> wrote on 12/15/2005 02:40:06 PM: On Thu, Dec 15, 2005 at 01:47:25PM +0100, Jens Osterkamp wrote: The driver incorrectly used dma_addr_t to describe HW structures and consequently broke when that type was changed in 2.6.15-rc. This

Re: [patch 4/5] spidernet: fix HW structures for 64 bit dma_addr_t

2005-12-20 Thread Jens Osterkamp
Christoph Hellwig <[EMAIL PROTECTED]> wrote on 12/15/2005 02:40:06 PM: > On Thu, Dec 15, 2005 at 01:47:25PM +0100, Jens Osterkamp wrote: > > > > The driver incorrectly used dma_addr_t to describe > > HW structures and consequently broke when that type > > was changed in 2.6.15-rc. > > > > This cha

Re: [patch 4/5] spidernet: fix HW structures for 64 bit dma_addr_t

2005-12-15 Thread Christoph Hellwig
On Thu, Dec 15, 2005 at 01:47:25PM +0100, Jens Osterkamp wrote: > > The driver incorrectly used dma_addr_t to describe > HW structures and consequently broke when that type > was changed in 2.6.15-rc. > > This changed spidernet to use u32 for 32 bit HW defined > structure elements. actually this