Re: [patch 2/9] IPv6/DCCP: fix memory leak in dccp_v6_do_rcv()

2006-10-21 Thread Arnaldo Carvalho de Melo
On 10/20/06, David Miller <[EMAIL PROTECTED]> wrote: From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:02 -0700 > (akpm: does opt_skb actually do anything?) This is a clone of similar code in net/ipv6/tcp_ipv6.c, it's just missing the bits at label "ipv6_pktoptions:" :-) No offence to the o

Re: [patch 2/9] IPv6/DCCP: fix memory leak in dccp_v6_do_rcv()

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:02 -0700 > (akpm: does opt_skb actually do anything?) This is a clone of similar code in net/ipv6/tcp_ipv6.c, it's just missing the bits at label "ipv6_pktoptions:" :-) No offence to the original patch, it's correct, but I'm going to fix this

[patch 2/9] IPv6/DCCP: fix memory leak in dccp_v6_do_rcv()

2006-10-20 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv() We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {" but at that point we may have allocated opt_skb, but we never free it in that path before the return. (akpm: