Re: [patch 2/3] netlink: allow removing multicast groups

2007-07-18 Thread Johannes Berg
On Tue, 2007-07-17 at 17:50 +0200, Patrick McHardy wrote: > Having the caller lock the table would save lots of atomic operation > in case of netlink_clear_multicast_users. Good point. > > +void netlink_clear_multicast_users(int unit, unsigned int group) > > Same as in the last patch, passing t

Re: [patch 2/3] netlink: allow removing multicast groups

2007-07-17 Thread Patrick McHardy
Johannes Berg wrote: > +static void netlink_update_socket_mc(struct netlink_sock *nlk, > + unsigned int group, > + int is_new) > +{ > + int old, new = !!is_new, subscriptions; > + > + netlink_table_grab(); Having the caller

[patch 2/3] netlink: allow removing multicast groups

2007-07-17 Thread Johannes Berg
Allow kicking listeners out of a multicast group when necessary (for example if that group is going to be removed.) Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- include/linux/netlink.h |1 + net/netlink/af_netlink.c | 47 ++- 2 files cha