Re: [patch 2/2] netxen: reversed condition in netxen_nic_set_link_parameters()

2016-05-07 Thread David Miller
From: Dan Carpenter Date: Thu, 5 May 2016 16:19:44 +0300 > My static checker complains that we are using "autoneg" without > initializing it. The problem is the ->phy_read() condition is reversed > so we only set this on error instead of success. > > Signed-off-by: Dan Carpenter Applied.

[patch 2/2] netxen: reversed condition in netxen_nic_set_link_parameters()

2016-05-05 Thread Dan Carpenter
My static checker complains that we are using "autoneg" without initializing it. The problem is the ->phy_read() condition is reversed so we only set this on error instead of success. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/eth