Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-07 Thread Jeff Garzik
David S. Miller wrote: From: Ingo Oeser <[EMAIL PROTECTED]> Date: Wed, 7 Sep 2005 15:39:08 +0200 Jeff Garzik wrote: I find them useful in my own drivers; they are definitely not pure noise. gcc -finstrument-functions I was going to mention this as well, and also the idea to enable CONFI

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-07 Thread David S. Miller
From: Ingo Oeser <[EMAIL PROTECTED]> Date: Wed, 7 Sep 2005 15:39:08 +0200 > Jeff Garzik wrote: > > I find them useful in my own drivers; they are definitely not pure noise. > > gcc -finstrument-functions I was going to mention this as well, and also the idea to enable CONFIG_MCOUNT on a per-file

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-07 Thread Ingo Oeser
Hi Jeff, Jeff Garzik wrote: > David S. Miller wrote: > > From: Jeff Garzik <[EMAIL PROTECTED]> > > Date: Tue, 06 Sep 2005 21:51:21 -0400 > > > >>NAK. Rationale: maintainer's choice. Pavel doesn't get to choose > >>the debugger of choice for the driver maintainer. > > > > If it makes the driver u

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-06 Thread Jeff Garzik
David S. Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 06 Sep 2005 21:51:21 -0400 NAK. Rationale: maintainer's choice. Pavel doesn't get to choose the debugger of choice for the driver maintainer. If it makes the driver unreadable and thus harder to maintain, I think such

Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

2005-09-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Pavel Machek <[EMAIL PROTECTED]> This removes debug prints from entry/exit of functions. Such level of debugging should probably be done by gdb or similar. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: "James P. Ketrenos"