Re: [patch 06/17] neighbour.c, pneigh_get_next() skips published entry

2006-06-09 Thread Jari Takkala
On Fri, 9 Jun 2006, Herbert Xu wrote: > Could you post an exact sequence of commands that reproduces the bug? > That would help us in verifying your fix. > Publish a large number of ARP entries (greater than 10 required on my system): 'arp -Ds pub' View output of /proc/net/arp: 'dd if=/proc

Re: [patch 06/17] neighbour.c, pneigh_get_next() skips published entry

2006-06-08 Thread Herbert Xu
Jari Takkala <[EMAIL PROTECTED]> wrote: > > I have not checked neigh seqfile iterators, the problem may exist in > there as well. My patch solves this issue for us, however a more elegant > solution would be most welcome. Could the root of the problem be that > *pos is off by one when pneigh_get_

Re: [patch 06/17] neighbour.c, pneigh_get_next() skips published entry

2006-06-08 Thread Jari Takkala
On Mon, 5 Jun 2006, David Miller wrote: > This patch doesn't make any sense, I've been over it a few times. > > The seqfile layer should take care of that user buffering issue transparently as > long as we implement the interface callbacks properly. > > Even if something needs to be fixed in the

Re: [patch 06/17] neighbour.c, pneigh_get_next() skips published entry

2006-06-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 01 Jun 2006 20:32:26 -0700 > From: "Jari Takkala" <[EMAIL PROTECTED]> > > Fix a problem where output from /proc/net/arp skips a record when the full > output does not fit into the users read() buffer. > > To reproduce: publish a large number of ARP entries (mor

[patch 06/17] neighbour.c, pneigh_get_next() skips published entry

2006-06-01 Thread akpm
From: "Jari Takkala" <[EMAIL PROTECTED]> Fix a problem where output from /proc/net/arp skips a record when the full output does not fit into the users read() buffer. To reproduce: publish a large number of ARP entries (more than 10 required on my system). Run 'dd if=/proc/net/arp of=arp-1024.ou