Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-26 Thread Jeff Garzik
Herbert Xu wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: +#ifdef CONFIG_DEBUG_SLAB + /* 82544's work arounds do not play nicely with DEBUG SLAB */ + if (adapter->hw.mac_type == e1000_82544) + netdev->features &= ~NETIF_F_TSO; +#endif NAK, same reason as the others Any ch

Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-16 Thread Jesse Brandeburg
On 12/15/06, Herbert Xu <[EMAIL PROTECTED]> wrote: Any chance you could apply this patch instead? I've verified that this does resolve the problem on 82544. [NETDRV] e1000: Do not truncate TSO TCP header with 82544 workaround Acked-by: Jesse Brandeburg <[EMAIL PROTECTED]> - To unsubscribe from

Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-15 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> +#ifdef CONFIG_DEBUG_SLAB >> + /* 82544's work arounds do not play nicely with DEBUG SLAB */ >> + if (adapter->hw.mac_type == e1000_82544) >> + netdev->features &= ~NETIF_F_TSO; >> +#endif > > NAK, same reason as the others Any cha

Re: [patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-15 Thread Jeff Garzik
Arjan van de Ven wrote: Subject: e1000: disable TSO on the 82544 with slab debugging From: Jesse Brandeburg <[EMAIL PROTECTED]> CONFIG_DEBUG_SLAB changes alignments of the data structures the slab allocators return. These break certain workarounds for TSO on the 82544. Since DEBUG_SLAB is relati

[patch 06/14] e1000: disable TSO on the 82544 with slab debugging

2006-12-15 Thread Arjan van de Ven
Subject: e1000: disable TSO on the 82544 with slab debugging From: Jesse Brandeburg <[EMAIL PROTECTED]> CONFIG_DEBUG_SLAB changes alignments of the data structures the slab allocators return. These break certain workarounds for TSO on the 82544. Since DEBUG_SLAB is relatively rare and not used for