Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Brandon Philips
On 14:44 Fri 03 Aug 2007, Stephen Hemminger wrote: > On Fri, 03 Aug 2007 20:33:04 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > > >> Devres makes low level drivers simpler, easier to get right and > > >> maintain. Writing new drivers becomes easier too. So, why not? > > >> > > >>> Network devices

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Stephen Hemminger
On Fri, 03 Aug 2007 20:33:04 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > Stephen Hemminger wrote: > >> Skimming through drivers... via-rhine doesn't disable PCI device on > >> init failure path but does so on removal. sky2 doesn't free > >> consistent memory if sky2_init() fails. ac

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Tejun Heo
Hello, Stephen Hemminger wrote: >> Skimming through drivers... via-rhine doesn't disable PCI device on >> init failure path but does so on removal. sky2 doesn't free >> consistent memory if sky2_init() fails. acenic calls iounmap() with >> NULL parameter which I'm not sure whether it's safe or n

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Stephen Hemminger
On Fri, 3 Aug 2007 19:26:45 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > On Fri, Aug 03, 2007 at 09:58:57AM +0100, Stephen Hemminger wrote: > > On Thu, 2 Aug 2007 15:42:06 -0700 > > Brandon Philips <[EMAIL PROTECTED]> wrote: > > > > > This patch set adds support for devres in the net core and con

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Tejun Heo
On Fri, Aug 03, 2007 at 09:58:57AM +0100, Stephen Hemminger wrote: > On Thu, 2 Aug 2007 15:42:06 -0700 > Brandon Philips <[EMAIL PROTECTED]> wrote: > > > This patch set adds support for devres in the net core and converts the > > e100 and e1000 drivers to devres. Devres is a simple resource manag

Re: [patch 0/5][RFC] Update network drivers to use devres

2007-08-03 Thread Stephen Hemminger
On Thu, 2 Aug 2007 15:42:06 -0700 Brandon Philips <[EMAIL PROTECTED]> wrote: > This patch set adds support for devres in the net core and converts the > e100 and e1000 drivers to devres. Devres is a simple resource manager > for device drivers, see Documentation/driver-model/devres.txt for more >

[patch 0/5][RFC] Update network drivers to use devres

2007-08-02 Thread Brandon Philips
This patch set adds support for devres in the net core and converts the e100 and e1000 drivers to devres. Devres is a simple resource manager for device drivers, see Documentation/driver-model/devres.txt for more information. The use of devres will remain optional for drivers with this patch set.