Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()

2017-03-22 Thread David Miller
From: Dan Carpenter Date: Wed, 22 Mar 2017 12:10:02 +0300 > Presumably if there is an "add" function, there is also a "del" > function. But it causes a static checker warning because it looks like > a common cut and paste bug. > > Signed-off-by: Dan Carpenter Looks good, applied, thanks Dan.

Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()

2017-03-22 Thread Jarod Wilson
On 2017-03-22 5:10 AM, Dan Carpenter wrote: Presumably if there is an "add" function, there is also a "del" function. But it causes a static checker warning because it looks like a common cut and paste bug. Signed-off-by: Dan Carpenter Agreed, looks like a cut-n-paste buglet. Acked-by: Jaro

[patch] sfc: cleanup a condition in efx_udp_tunnel_del()

2017-03-22 Thread Dan Carpenter
Presumably if there is an "add" function, there is also a "del" function. But it causes a static checker warning because it looks like a common cut and paste bug. Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 8c4c273643dc..203c8c