Re: [patch] rds: fix an integer overflow test in rds_info_getsockopt()

2015-08-03 Thread David Miller
From: Dan Carpenter Date: Sat, 1 Aug 2015 15:33:26 +0300 > "len" is a signed integer. We check that len is not negative, so it > goes from zero to INT_MAX. PAGE_SIZE is unsigned long so the comparison > is type promoted to unsigned long. ULONG_MAX - 4095 is a higher than > INT_MAX so the condi

[patch] rds: fix an integer overflow test in rds_info_getsockopt()

2015-08-01 Thread Dan Carpenter
"len" is a signed integer. We check that len is not negative, so it goes from zero to INT_MAX. PAGE_SIZE is unsigned long so the comparison is type promoted to unsigned long. ULONG_MAX - 4095 is a higher than INT_MAX so the condition can never be true. I don't know if this is harmful but it see