Re: [patch] qlcnic: fix a timeout loop

2015-12-15 Thread walter harms
5, 2015 3:46 PM >> To: Dept-GE Linux NIC Dev ; Rajesh >> Borundia >> Cc: netdev ; kernel-janit...@vger.kernel.org >> Subject: [patch] qlcnic: fix a timeout loop >> >> The problem here is that at the end of the loop we test for if >> idc->vnic_wait_limit

RE: [patch] qlcnic: fix a timeout loop

2015-12-15 Thread Manish Chopra
orundia > Cc: netdev ; kernel-janit...@vger.kernel.org > Subject: [patch] qlcnic: fix a timeout loop > > The problem here is that at the end of the loop we test for if > idc->vnic_wait_limit is zero, but since idc->vnic_wait_limit-- is a > post-op, it actually ends up set to (u

[patch] qlcnic: fix a timeout loop

2015-12-15 Thread Dan Carpenter
The problem here is that at the end of the loop we test for if idc->vnic_wait_limit is zero, but since idc->vnic_wait_limit-- is a post-op, it actually ends up set to (u8)-1. I have fixed this by changing it to a pre-op. I had to change the starting value from "QLCNIC_DEV_NPAR_OPER_TIMEO" (30) to