Re: [patch] net: moxa: fix an error code

2016-03-03 Thread David Miller
From: Dan Carpenter Date: Wed, 2 Mar 2016 13:11:10 +0300 > We accidentally return IS_ERR(priv->base) which is 1 instead of > PTR_ERR(priv->base) which is the error code. > > Fixes: 6c821bd9edc9 ('net: Add MOXA ART SoCs ethernet driver') > Signed-off-by: Dan Carpenter Applied, thank you Dan.

Re: [patch] net: moxa: fix an error code

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 15:15:26 Dan Carpenter wrote: > On Wed, Mar 02, 2016 at 12:36:05PM +0100, Arnd Bergmann wrote: > > The uninitialized warning here is about a type mismatch preventing > > gcc from noticing that two conditions are the same, I'm not sure > > if this is a bug in gcc, or requi

Re: [patch] net: moxa: fix an error code

2016-03-02 Thread Dan Carpenter
On Wed, Mar 02, 2016 at 12:36:05PM +0100, Arnd Bergmann wrote: > The uninitialized warning here is about a type mismatch preventing > gcc from noticing that two conditions are the same, I'm not sure > if this is a bug in gcc, or required by the C standard. I wouldn't call it a bug, because everyon

Re: [patch] net: moxa: fix an error code

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 14:21:29 Dan Carpenter wrote: > On Wed, Mar 02, 2016 at 11:52:29AM +0100, Arnd Bergmann wrote: > > Did you find more of these? > > > > it doesn't matter much either way, but if you do multiple such patches, > > One or two. I already sent the fixes. I think it was appl

Re: [patch] net: moxa: fix an error code

2016-03-02 Thread Dan Carpenter
On Wed, Mar 02, 2016 at 11:52:29AM +0100, Arnd Bergmann wrote: > Did you find more of these? > > it doesn't matter much either way, but if you do multiple such patches, One or two. I already sent the fixes. I think it was applied. > I'd suggest using a single PTR_ERR_OR_ZERO() instead of IS_ER

Re: [patch] net: moxa: fix an error code

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 13:11:10 Dan Carpenter wrote: > We accidentally return IS_ERR(priv->base) which is 1 instead of > PTR_ERR(priv->base) which is the error code. > > Fixes: 6c821bd9edc9 ('net: Add MOXA ART SoCs ethernet driver') > Signed-off-by: Dan Carpenter Acked-by: Arnd Bergmann ni

[patch] net: moxa: fix an error code

2016-03-02 Thread Dan Carpenter
We accidentally return IS_ERR(priv->base) which is 1 instead of PTR_ERR(priv->base) which is the error code. Fixes: 6c821bd9edc9 ('net: Add MOXA ART SoCs ethernet driver') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether