Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-14 Thread Leon Romanovsky
On Wed, Jul 13, 2016 at 02:40:26PM +0300, Or Gerlitz wrote: > On 7/13/2016 2:19 PM, Matan Barak wrote: > >I'm not sure EINVAL is the right error here though. > >Maybe -ENOTSUPP is a bit more appropriate here. > > I agree, Dan, can you please change to be along Matan's suggestion? Or, Dan already

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-14 Thread Or Gerlitz
On 7/13/2016 2:19 PM, Matan Barak wrote: I'm not sure EINVAL is the right error here though. Maybe -ENOTSUPP is a bit more appropriate here. I agree, Dan, can you please change to be along Matan's suggestion? Or.

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Matan Barak
On 13/07/2016 13:08, Dan Carpenter wrote: We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Leon Romanovsky
On Wed, Jul 13, 2016 at 01:08:25PM +0300, Dan Carpenter wrote: > We accidentally return success when we had intended to return an error > code. > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads > mode') > Signed-off-by: Dan Carpenter Thanks Dan, Reviewed-by: Leon

[patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Dan Carpenter
We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/