Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-15 Thread Ingo Molnar
* Heiko Carstens <[EMAIL PROTECTED]> wrote: > How about the patch below? The warning goes away and I assume > "tmp_list" needs lockdep_reinit_key too, since it should have the same > locking rules as the rest of qeth's skb-queue management. yeah, looks good. Ingo - To unsubscribe from

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Heiko Carstens
On Thu, Jun 15, 2006 at 08:28:07AM +0200, Ingo Molnar wrote: > > * Herbert Xu <[EMAIL PROTECTED]> wrote: > > > This is bogus. These two locks belong to two different queues and > > they never intersect. > > yeah - qeth does its own skb-queue management here, and it's done in an > irq-safe man

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > This is bogus. These two locks belong to two different queues and > they never intersect. yeah - qeth does its own skb-queue management here, and it's done in an irq-safe manner. Heiko, in qeth_main.c, could you do something like: + static struct lo

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Herbert Xu
Heiko Carstens <[EMAIL PROTECTED]> wrote: > > As reported by the lock validator: > > > [ BUG: illegal lock usage! ] > > illegal {in-hardirq-W} -> {hardirq-on-W} usage. > syslogd/739 [HC0[0]:SC0[1]:HE1:SE0] takes: > (&list->lock){++..}, at:

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread David Miller
From: Heiko Carstens <[EMAIL PROTECTED]> Date: Wed, 14 Jun 2006 21:43:05 +0200 > From: Heiko Carstens <[EMAIL PROTECTED]> > > Fix lock usage in udp_ioctl(). > > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> More likely the qeth driver shouldn't call into the socket code in hardware interrup

[patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Fix lock usage in udp_ioctl(). Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- udp_poll() seems to have the same problem, right? As reported by the lock validator: [ BUG: illegal lock usage! ] -