Re: [patch] drivers/net/3c59x: notice carrier a little sooner

2006-01-13 Thread Steffen Klassert
On Thu, Jan 12, 2006 at 09:04:31PM -0500, Dan Williams wrote: > > I still have a patch in queue to improve usage of netif_carrier_{on,off} > > but I had no possibility to test yet, so I did not send. > > I'd be happy to test it out if you'd like. > This would be great. I will rediff against ne

Re: [patch] drivers/net/3c59x: notice carrier a little sooner

2006-01-12 Thread Dan Williams
On Thu, 12 Jan 2006, Steffen Klassert wrote: > On Thu, Jan 12, 2006 at 03:02:25PM -0500, Dan Williams wrote: > > On Thu, 2006-01-12 at 20:57 +0100, Steffen Klassert wrote: > > > Did you give the patch a try? > > > > > > Actually I have no possibility to test, but > > > I think that netif_carrier_

Re: [patch] drivers/net/3c59x: notice carrier a little sooner

2006-01-12 Thread Steffen Klassert
On Thu, Jan 12, 2006 at 03:02:25PM -0500, Dan Williams wrote: > On Thu, 2006-01-12 at 20:57 +0100, Steffen Klassert wrote: > > Did you give the patch a try? > > > > Actually I have no possibility to test, but > > I think that netif_carrier_{on,off} still does not > > work proper. The timer functio

Re: [patch] drivers/net/3c59x: notice carrier a little sooner

2006-01-12 Thread Dan Williams
On Thu, 2006-01-12 at 20:57 +0100, Steffen Klassert wrote: > Did you give the patch a try? > > Actually I have no possibility to test, but > I think that netif_carrier_{on,off} still does not > work proper. The timer function does just nothing > if vp->medialock is set. > Worked for me with 3c905

Re: [patch] drivers/net/3c59x: notice carrier a little sooner

2006-01-12 Thread Steffen Klassert
Did you give the patch a try? Actually I have no possibility to test, but I think that netif_carrier_{on,off} still does not work proper. The timer function does just nothing if vp->medialock is set. Steffen On Thu, Jan 12, 2006 at 01:29:23PM -0500, Dan Williams wrote: > Hi, > > This patch att

[patch] drivers/net/3c59x: notice carrier a little sooner

2006-01-12 Thread Dan Williams
Hi, This patch attempts to notice carrier 'on' state a little sooner. Since the carrier watchdog only fires in really, really long intervals (like, 60s in most cases), it takes up to 60s to notice that a cable has been plugged/unplugged. This patch fires the carrier watchdog if (1) the carrier i