Re: [patch] add net_device_stats support to ethtool

Jeff Garzik <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Hi, > > > > I have posted this patch in the past with absolutely no reply. > > I would appreciate some sort of feedback of the form interested/not > > interested. Should I just drop it? > > > > "ethtool -S" only s

Re: [patch] add net_device_stats support to ethtool

Dan Nicolaescu wrote: Hi, I have posted this patch in the past with absolutely no reply. I would appreciate some sort of feedback of the form interested/not interested. Should I just drop it? "ethtool -S" only supports devices that have custom code written to print the stats. No -- more s

Re: [patch] add net_device_stats support to ethtool

Ben Greear <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Ben Greear <[EMAIL PROTECTED]> writes: > > > > > Dan Nicolaescu wrote: > > > > Hi, > > > > > > > > I have posted this patch in the past with absolutely no reply. > > > > I would appreciate some sort of fee

Re: [patch] add net_device_stats support to ethtool

Dan Nicolaescu wrote: Ben Greear <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Hi, > > > > I have posted this patch in the past with absolutely no reply. > > I would appreciate some sort of feedback of the form interested/not > > interested. Should I just drop it? > >

Re: [patch] add net_device_stats support to ethtool

Ben Greear <[EMAIL PROTECTED]> writes: > Dan Nicolaescu wrote: > > Hi, > > > > I have posted this patch in the past with absolutely no reply. > > I would appreciate some sort of feedback of the form interested/not > > interested. Should I just drop it? > > > > > I like it, bu

Re: [patch] add net_device_stats support to ethtool

Dan Nicolaescu wrote: Hi, I have posted this patch in the past with absolutely no reply. I would appreciate some sort of feedback of the form interested/not interested. Should I just drop it? I like it, but why not offer this for all devices since they all have these stats. Could add ne

[patch] add net_device_stats support to ethtool

Hi, I have posted this patch in the past with absolutely no reply. I would appreciate some sort of feedback of the form interested/not interested. Should I just drop it? "ethtool -S" only supports devices that have custom code written to print the stats. A lot of drivers use "struct net_devi

[patch] add net_device_stats support to ethtool

Hi, "ethtool -S" only supports devices that have custom code written to print the stats. A lot of drivers use "struct net_device_stats", so adding code to ethtool would make it very easy for such drivers to add support for "ethtool -S". The drivers would just need to add this: .get_strin