Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-17 Thread Steffen Klassert
On Tue, Jan 17, 2006 at 03:02:45AM -0800, Andrew Morton wrote: > Steffen Klassert <[EMAIL PROTECTED]> wrote: > > > > The patch _should_ do the following: > > > > 1. Set the polling intervall for media changes to 5 seconds if link is > > down > > and 60 seconds if link is up. > > 2. Handle net

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-17 Thread Andrew Morton
Steffen Klassert <[EMAIL PROTECTED]> wrote: > > The patch _should_ do the following: > > 1. Set the polling intervall for media changes to 5 seconds if link is down > and 60 seconds if link is up. > 2. Handle netif_carrier_{on,of} and check for media changes in > proper way by using mii_chec

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-16 Thread Steffen Klassert
On Mon, Jan 16, 2006 at 02:43:30PM -0500, Dan Williams wrote: ... > The patch appears to work correctly and does notice links quite a bit > sooner. The only issue I noticed was that if no cable is plugged in, it > starts off with the carrier on (/sys/class/net/eth0/carrier == "1") but > a second l

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-16 Thread Dan Williams
On Fri, 2006-01-13 at 18:09 +0100, Steffen Klassert wrote: > ... > > > I still have a patch in queue to improve usage of netif_carrier_{on,off} > > > but I had no possibility to test yet, so I did not send. > > > > I'd be happy to test it out if you'd like. > > > > Dan > > Hi Dan, > > here is

[patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-13 Thread Steffen Klassert
... > > I still have a patch in queue to improve usage of netif_carrier_{on,off} > > but I had no possibility to test yet, so I did not send. > > I'd be happy to test it out if you'd like. > > Dan Hi Dan, here is the patch for testing. The patch _should_ do the following: 1. Set the polling