Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow

2020-10-02 Thread Saeed Mahameed
On Fri, 2020-10-02 at 10:19 -0700, Mark Bloch wrote: > > On 10/2/2020 10:05, Saeed Mahameed wrote: > > On Thu, 2020-10-01 at 16:24 -0700, Jakub Kicinski wrote: > > > On Thu, 1 Oct 2020 12:52:39 -0700 sa...@kernel.org wrote: > > > > - for (; i >= 0; i--) { > > > > + for (--i; i >= 0; i

Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow

2020-10-02 Thread Mark Bloch
On 10/2/2020 10:05, Saeed Mahameed wrote: > On Thu, 2020-10-01 at 16:24 -0700, Jakub Kicinski wrote: >> On Thu, 1 Oct 2020 12:52:39 -0700 sa...@kernel.org wrote: >>> - for (; i >= 0; i--) { >>> + for (--i; i >= 0; i--) { >> >> while (i--) > > while(--i) It has to be: while (i--) Case of i

Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow

2020-10-02 Thread Saeed Mahameed
On Thu, 2020-10-01 at 16:24 -0700, Jakub Kicinski wrote: > On Thu, 1 Oct 2020 12:52:39 -0700 sa...@kernel.org wrote: > > - for (; i >= 0; i--) { > > + for (--i; i >= 0; i--) { > > while (i--) while(--i) I like this, less characters to maintain :)

Re: [net V2 07/15] net/mlx5: Fix request_irqs error flow

2020-10-01 Thread Jakub Kicinski
On Thu, 1 Oct 2020 12:52:39 -0700 sa...@kernel.org wrote: > - for (; i >= 0; i--) { > + for (--i; i >= 0; i--) { while (i--)

[net V2 07/15] net/mlx5: Fix request_irqs error flow

2020-10-01 Thread saeed
From: Maor Gottlieb Fix error flow handling in request_irqs which try to free irq that we failed to request. It fixes the below trace. WARNING: CPU: 1 PID: 7587 at kernel/irq/manage.c:1684 free_irq+0x4d/0x60 CPU: 1 PID: 7587 Comm: bash Tainted: GW OE 4.15.15-1.el7MELLANOXsmp-x86_64