Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2017 at 02:12:47PM -0800, John Fastabend wrote: > On 17-01-23 12:09 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 23, 2017 at 09:22:36PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > >>> diff --git a/drivers/net/virtio_net.c

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-23 Thread John Fastabend
On 17-01-23 12:09 PM, Michael S. Tsirkin wrote: > On Mon, Jan 23, 2017 at 09:22:36PM +0200, Michael S. Tsirkin wrote: >> On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: >>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >>> index 62dbf4b..3b129b4 100644 >>> --- a/d

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-23 Thread Michael S. Tsirkin
On Mon, Jan 23, 2017 at 09:22:36PM +0200, Michael S. Tsirkin wrote: > On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 62dbf4b..3b129b4 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virti

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-23 Thread Michael S. Tsirkin
On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 62dbf4b..3b129b4 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -41,6 +41,9 @@ > #define GOOD_PACKET_LEN (ETH_HLEN + VLAN_HLEN +

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-23 Thread Michael S. Tsirkin
On Sat, Jan 21, 2017 at 08:14:19PM -0800, John Fastabend wrote: > On 17-01-21 06:51 PM, Jason Wang wrote: > > > > > > On 2017年01月21日 01:48, Michael S. Tsirkin wrote: > >> On Fri, Jan 20, 2017 at 04:59:11PM +, David Laight wrote: > >>> From: Michael S. Tsirkin > Sent: 19 January 2017 21:1

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-21 Thread John Fastabend
On 17-01-21 06:51 PM, Jason Wang wrote: > > > On 2017年01月21日 01:48, Michael S. Tsirkin wrote: >> On Fri, Jan 20, 2017 at 04:59:11PM +, David Laight wrote: >>> From: Michael S. Tsirkin Sent: 19 January 2017 21:12 > On 2017?01?18? 23:15, Michael S. Tsirkin wrote: >> On Tue, Jan 17,

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-21 Thread Jason Wang
On 2017年01月21日 01:48, Michael S. Tsirkin wrote: On Fri, Jan 20, 2017 at 04:59:11PM +, David Laight wrote: From: Michael S. Tsirkin Sent: 19 January 2017 21:12 On 2017?01?18? 23:15, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: Add support for

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-20 Thread Michael S. Tsirkin
On Fri, Jan 20, 2017 at 04:59:11PM +, David Laight wrote: > From: Michael S. Tsirkin > > Sent: 19 January 2017 21:12 > > > On 2017?01?18? 23:15, Michael S. Tsirkin wrote: > > > > On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > > > > > Add support for XDP adjust head by allocat

RE: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-20 Thread David Laight
From: Michael S. Tsirkin > Sent: 19 January 2017 21:12 > > On 2017?01?18? 23:15, Michael S. Tsirkin wrote: > > > On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > > > > Add support for XDP adjust head by allocating a 256B header region > > > > that XDP programs can grow into. This i

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-19 Thread John Fastabend
On 17-01-19 07:26 PM, Jason Wang wrote: > > > On 2017年01月20日 05:11, Michael S. Tsirkin wrote: >> On Thu, Jan 19, 2017 at 11:05:40AM +0800, Jason Wang wrote: >>> >>> On 2017年01月18日 23:15, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > Add suppo

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-19 Thread John Fastabend
On 17-01-19 01:11 PM, Michael S. Tsirkin wrote: > On Thu, Jan 19, 2017 at 11:05:40AM +0800, Jason Wang wrote: >> >> >> On 2017年01月18日 23:15, Michael S. Tsirkin wrote: >>> On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: Add support for XDP adjust head by allocating a 256B header

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-19 Thread Jason Wang
On 2017年01月20日 05:11, Michael S. Tsirkin wrote: On Thu, Jan 19, 2017 at 11:05:40AM +0800, Jason Wang wrote: On 2017年01月18日 23:15, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: Add support for XDP adjust head by allocating a 256B header region that

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2017 at 11:05:40AM +0800, Jason Wang wrote: > > > On 2017年01月18日 23:15, Michael S. Tsirkin wrote: > > On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > > > Add support for XDP adjust head by allocating a 256B header region > > > that XDP programs can grow into. Thi

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-18 Thread Jason Wang
On 2017年01月18日 23:15, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-18 Thread Michael S. Tsirkin
On Tue, Jan 17, 2017 at 02:22:59PM -0800, John Fastabend wrote: > Add support for XDP adjust head by allocating a 256B header region > that XDP programs can grow into. This is only enabled when a XDP > program is loaded. > > In order to ensure that we do not have to unwind queue headroom push > qu

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-17 Thread Jason Wang
On 2017年01月18日 06:22, John Fastabend wrote: +static int virtnet_reset(struct virtnet_info *vi) +{ + struct virtio_device *dev = vi->vdev; + int ret; + + virtio_config_disable(dev); + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; + virtnet_

[net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-17 Thread John Fastabend
Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do not have to unwind queue headroom push queue setup below bpf_prog_add. It reads better to do a prog ref unwind vs ano