Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2017-01-11 Thread Stephen Rothwell
Hi Dave, On Tue, 29 Nov 2016 20:07:08 +1100 Stephen Rothwell wrote: > > Hi Jeff, > > On Tue, 29 Nov 2016 10:43:04 +1100 Stephen Rothwell > wrote: > > > > On Mon, 28 Nov 2016 14:26:02 -0800 Jeff Kirsher > > wrote: > > > > > > On Mon, 2016-11-28 at 10:42 -0500, Alexander Duyck wrote: >

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-12-01 Thread David Miller
From: Jeff Kirsher Date: Wed, 30 Nov 2016 13:15:22 -0800 > On Wed, 2016-11-30 at 09:47 -0500, David Miller wrote: >> From: Alexander Duyck >> Date: Mon, 28 Nov 2016 10:42:18 -0500 >> >> > When I implemented the GSO partial support in the Intel drivers I was >> using >> > lco_csum to compute the

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-11-30 Thread Jeff Kirsher
On Wed, 2016-11-30 at 09:47 -0500, David Miller wrote: > From: Alexander Duyck > Date: Mon, 28 Nov 2016 10:42:18 -0500 > > > When I implemented the GSO partial support in the Intel drivers I was > using > > lco_csum to compute the checksum that we needed to plug into the IPv4 > > checksum field i

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-11-30 Thread David Miller
From: Alexander Duyck Date: Mon, 28 Nov 2016 10:42:18 -0500 > When I implemented the GSO partial support in the Intel drivers I was using > lco_csum to compute the checksum that we needed to plug into the IPv4 > checksum field in order to cancel out the data that was not a part of the > IPv4 head

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-11-29 Thread Stephen Rothwell
Hi Jeff, On Tue, 29 Nov 2016 10:43:04 +1100 Stephen Rothwell wrote: > > On Mon, 28 Nov 2016 14:26:02 -0800 Jeff Kirsher > wrote: > > > > On Mon, 2016-11-28 at 10:42 -0500, Alexander Duyck wrote: > > > When I implemented the GSO partial support in the Intel drivers I was > > > using > > > lco

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-11-28 Thread Stephen Rothwell
Hi Jeff, On Mon, 28 Nov 2016 14:26:02 -0800 Jeff Kirsher wrote: > > On Mon, 2016-11-28 at 10:42 -0500, Alexander Duyck wrote: > > When I implemented the GSO partial support in the Intel drivers I was > > using > > lco_csum to compute the checksum that we needed to plug into the IPv4 > > checksum

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-11-28 Thread Jeff Kirsher
On Mon, 2016-11-28 at 10:42 -0500, Alexander Duyck wrote: > When I implemented the GSO partial support in the Intel drivers I was > using > lco_csum to compute the checksum that we needed to plug into the IPv4 > checksum field in order to cancel out the data that was not a part of the > IPv4 header

[net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-11-28 Thread Alexander Duyck
When I implemented the GSO partial support in the Intel drivers I was using lco_csum to compute the checksum that we needed to plug into the IPv4 checksum field in order to cancel out the data that was not a part of the IPv4 header. However this didn't take into account that the transport offset m