Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-10 Thread Jason Wang
On 2017年01月10日 13:00, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 08:25:43PM -0800, John Fastabend wrote: On 17-01-09 07:55 PM, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 07:30:34PM -0800, John Fastabend wrote: On 17-01-09 06:51 PM, Michael S. Tsirkin wrote: On Tue, Jan 10, 201

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-10 Thread Michael S. Tsirkin
On Tue, Jan 10, 2017 at 04:51:34AM +0200, Michael S. Tsirkin wrote: > XDP seems to have a bunch of weird restrictions, I just > do not like it that the logic spills out to all drivers. > What if someone decides to extend it to two pages in the future? > Recode it all in all drivers ... > > Why can

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 08:25:43PM -0800, John Fastabend wrote: > On 17-01-09 07:55 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2017 at 07:30:34PM -0800, John Fastabend wrote: > >> On 17-01-09 06:51 PM, Michael S. Tsirkin wrote: > >>> On Tue, Jan 10, 2017 at 10:29:39AM +0800, Jason Wang wrote

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread John Fastabend
On 17-01-09 07:55 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2017 at 07:30:34PM -0800, John Fastabend wrote: >> On 17-01-09 06:51 PM, Michael S. Tsirkin wrote: >>> On Tue, Jan 10, 2017 at 10:29:39AM +0800, Jason Wang wrote: On 2017年01月10日 07:58, Michael S. Tsirkin wrote: > O

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 07:30:34PM -0800, John Fastabend wrote: > On 17-01-09 06:51 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 10, 2017 at 10:29:39AM +0800, Jason Wang wrote: > >> > >> > >> On 2017年01月10日 07:58, Michael S. Tsirkin wrote: > >>> On Mon, Jan 09, 2017 at 03:49:27PM -0800, John Fasta

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Jason Wang
On 2017年01月10日 10:51, Michael S. Tsirkin wrote: On Tue, Jan 10, 2017 at 10:29:39AM +0800, Jason Wang wrote: On 2017年01月10日 07:58, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 03:49:27PM -0800, John Fastabend wrote: On 17-01-09 03:24 PM, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 a

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread John Fastabend
On 17-01-09 06:51 PM, Michael S. Tsirkin wrote: > On Tue, Jan 10, 2017 at 10:29:39AM +0800, Jason Wang wrote: >> >> >> On 2017年01月10日 07:58, Michael S. Tsirkin wrote: >>> On Mon, Jan 09, 2017 at 03:49:27PM -0800, John Fastabend wrote: On 17-01-09 03:24 PM, Michael S. Tsirkin wrote: > On Mo

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Michael S. Tsirkin
On Tue, Jan 10, 2017 at 10:29:39AM +0800, Jason Wang wrote: > > > On 2017年01月10日 07:58, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2017 at 03:49:27PM -0800, John Fastabend wrote: > > > On 17-01-09 03:24 PM, Michael S. Tsirkin wrote: > > > > On Mon, Jan 09, 2017 at 03:13:15PM -0800, John Fastab

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Jason Wang
On 2017年01月10日 07:58, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 03:49:27PM -0800, John Fastabend wrote: On 17-01-09 03:24 PM, Michael S. Tsirkin wrote: On Mon, Jan 09, 2017 at 03:13:15PM -0800, John Fastabend wrote: On 17-01-09 03:05 PM, Michael S. Tsirkin wrote: On Thu, Jan 05, 201

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 03:49:27PM -0800, John Fastabend wrote: > On 17-01-09 03:24 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 09, 2017 at 03:13:15PM -0800, John Fastabend wrote: > >> On 17-01-09 03:05 PM, Michael S. Tsirkin wrote: > >>> On Thu, Jan 05, 2017 at 11:09:14AM +0800, Jason Wang wrote

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread John Fastabend
On 17-01-09 03:24 PM, Michael S. Tsirkin wrote: > On Mon, Jan 09, 2017 at 03:13:15PM -0800, John Fastabend wrote: >> On 17-01-09 03:05 PM, Michael S. Tsirkin wrote: >>> On Thu, Jan 05, 2017 at 11:09:14AM +0800, Jason Wang wrote: On 2017年01月05日 02:57, John Fastabend wrote: > [...]

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Michael S. Tsirkin
On Mon, Jan 09, 2017 at 03:13:15PM -0800, John Fastabend wrote: > On 17-01-09 03:05 PM, Michael S. Tsirkin wrote: > > On Thu, Jan 05, 2017 at 11:09:14AM +0800, Jason Wang wrote: > >> > >> > >> On 2017年01月05日 02:57, John Fastabend wrote: > >>> [...] > >>> > On 2017年01月04日 00:48, John Fastabend

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread John Fastabend
On 17-01-09 03:05 PM, Michael S. Tsirkin wrote: > On Thu, Jan 05, 2017 at 11:09:14AM +0800, Jason Wang wrote: >> >> >> On 2017年01月05日 02:57, John Fastabend wrote: >>> [...] >>> On 2017年01月04日 00:48, John Fastabend wrote: > On 17-01-02 10:14 PM, Jason Wang wrote: >> On 2017年01月03日 06:30

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-09 Thread Michael S. Tsirkin
On Thu, Jan 05, 2017 at 11:09:14AM +0800, Jason Wang wrote: > > > On 2017年01月05日 02:57, John Fastabend wrote: > > [...] > > > > > On 2017年01月04日 00:48, John Fastabend wrote: > > > > On 17-01-02 10:14 PM, Jason Wang wrote: > > > > > On 2017年01月03日 06:30, John Fastabend wrote: > > > > > > XDP prog

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-04 Thread Jason Wang
On 2017年01月05日 02:57, John Fastabend wrote: [...] On 2017年01月04日 00:48, John Fastabend wrote: On 17-01-02 10:14 PM, Jason Wang wrote: On 2017年01月03日 06:30, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-04 Thread John Fastabend
[...] > On 2017年01月04日 00:48, John Fastabend wrote: >> On 17-01-02 10:14 PM, Jason Wang wrote: >>> >>> On 2017年01月03日 06:30, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-03 Thread Jason Wang
case. On 2017年01月04日 00:48, John Fastabend wrote: On 17-01-02 10:14 PM, Jason Wang wrote: On 2017年01月03日 06:30, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program load and does not bl

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-03 Thread John Fastabend
On 17-01-02 10:14 PM, Jason Wang wrote: > > > On 2017年01月03日 06:30, John Fastabend wrote: >> XDP programs can not consume multiple pages so we cap the MTU to >> avoid this case. Virtio-net however only checks the MTU at XDP >> program load and does not block MTU changes after the program >> has l

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-03 Thread John Fastabend
On 17-01-02 10:14 PM, Jason Wang wrote: > > > On 2017年01月03日 06:30, John Fastabend wrote: >> XDP programs can not consume multiple pages so we cap the MTU to >> avoid this case. Virtio-net however only checks the MTU at XDP >> program load and does not block MTU changes after the program >> has l

Re: [net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-02 Thread Jason Wang
On 2017年01月03日 06:30, John Fastabend wrote: XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program load and does not block MTU changes after the program has loaded. This patch sets/clears the max_mtu value at XDP

[net PATCH] net: virtio: cap mtu when XDP programs are running

2017-01-02 Thread John Fastabend
XDP programs can not consume multiple pages so we cap the MTU to avoid this case. Virtio-net however only checks the MTU at XDP program load and does not block MTU changes after the program has loaded. This patch sets/clears the max_mtu value at XDP load/unload time. Signed-off-by: John Fastabend