Re: [net PATCH] net: sched, fix OOO packets with pfifo_fast

2018-03-24 Thread John Fastabend
On 03/24/2018 02:15 PM, Eric Dumazet wrote: > > > On 03/24/2018 01:13 PM, John Fastabend wrote: >> After the qdisc lock was dropped in pfifo_fast we allow multiple >> enqueue threads and dequeue threads to run in parallel. On the >> enqueue side the skb bit ooo_okay is used to ensure all related

Re: [net PATCH] net: sched, fix OOO packets with pfifo_fast

2018-03-24 Thread Eric Dumazet
On 03/24/2018 01:13 PM, John Fastabend wrote: > After the qdisc lock was dropped in pfifo_fast we allow multiple > enqueue threads and dequeue threads to run in parallel. On the > enqueue side the skb bit ooo_okay is used to ensure all related > skbs are enqueued in-order. On the dequeue side tho

[net PATCH] net: sched, fix OOO packets with pfifo_fast

2018-03-24 Thread John Fastabend
After the qdisc lock was dropped in pfifo_fast we allow multiple enqueue threads and dequeue threads to run in parallel. On the enqueue side the skb bit ooo_okay is used to ensure all related skbs are enqueued in-order. On the dequeue side though there is no similar logic. What we observe is with f