On Tue, 7 Jul 2020 03:29:18 + Saeed Mahameed wrote:
> On Mon, 2020-07-06 at 19:07 -0700, Jakub Kicinski wrote:
> > On Tue, 7 Jul 2020 01:51:21 + Saeed Mahameed wrote:
> > > > Also looks like you report the total number of mcast packets in
> > > > ethtool
> > > > -S, which should be identi
On Mon, 2020-07-06 at 19:07 -0700, Jakub Kicinski wrote:
> On Tue, 7 Jul 2020 01:51:21 + Saeed Mahameed wrote:
> > > Also looks like you report the total number of mcast packets in
> > > ethtool
> > > -S, which should be identical to ip -s? If so please remove
> > > that.
> >
> > why ? it is
On Tue, 7 Jul 2020 01:51:21 + Saeed Mahameed wrote:
> > Also looks like you report the total number of mcast packets in
> > ethtool
> > -S, which should be identical to ip -s? If so please remove that.
>
> why ? it is ok to report the same counter both in ehttool and netdev
> stats.
I don't
On Mon, 2020-07-06 at 12:57 -0700, Jakub Kicinski wrote:
> On Mon, 6 Jul 2020 19:40:50 + Saeed Mahameed wrote:
> > > I don't really feel too strongly, I'm just trying to get the
> > > details
> > > because I feel like the situation is going to be increasingly
> > > common.
> > > It'd be quite s
On Mon, 6 Jul 2020 19:40:50 + Saeed Mahameed wrote:
> > I don't really feel too strongly, I'm just trying to get the details
> > because I feel like the situation is going to be increasingly common.
> > It'd be quite sad if drivers had to reimplement all stats in sw.
>
> Depends on HW, our HW/
On Fri, 2020-07-03 at 10:59 -0700, Jakub Kicinski wrote:
> On Fri, 3 Jul 2020 06:15:09 + Saeed Mahameed wrote:
> > > > To read mcast counter we need to execute FW command which is
> > > > blocking,
> > > > we can't block in atomic context .ndo_get_stats64 :( .. we have
> > > > to
> > > > count
On Fri, 3 Jul 2020 06:15:09 + Saeed Mahameed wrote:
> > > To read mcast counter we need to execute FW command which is
> > > blocking,
> > > we can't block in atomic context .ndo_get_stats64 :( .. we have to
> > > count in SW.
> > >
> > > the previous approach wasn't accurate as we read the m
On Thu, 2020-07-02 at 21:25 -0700, Jakub Kicinski wrote:
> On Fri, 3 Jul 2020 03:45:45 + Saeed Mahameed wrote:
> > On Thu, 2020-07-02 at 18:47 -0700, Jakub Kicinski wrote:
> > > On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> > > > From: Ron Diskin
> > > >
> > > > Currently the F
On Fri, 3 Jul 2020 03:45:45 + Saeed Mahameed wrote:
> On Thu, 2020-07-02 at 18:47 -0700, Jakub Kicinski wrote:
> > On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> > > From: Ron Diskin
> > >
> > > Currently the FW does not generate events for counters other than
> > > error
> > >
On Thu, 2020-07-02 at 18:47 -0700, Jakub Kicinski wrote:
> On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> > From: Ron Diskin
> >
> > Currently the FW does not generate events for counters other than
> > error
> > counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip
> >
On Thu, 2 Jul 2020 15:19:14 -0700 Saeed Mahameed wrote:
> From: Ron Diskin
>
> Currently the FW does not generate events for counters other than error
> counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip -s
> uses) might run in atomic context, while the FW interface is non atomi
From: Ron Diskin
Currently the FW does not generate events for counters other than error
counters. Unlike ".get_ethtool_stats", ".ndo_get_stats64" (which ip -s
uses) might run in atomic context, while the FW interface is non atomic.
Thus, 'ip' is not allowed to issue fw commands, so it will only
12 matches
Mail list logo
