Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-09 Thread Jakub Kicinski
On Fri, 9 Aug 2019 18:49:50 +, Saeed Mahameed wrote: > On Thu, 2019-08-08 at 18:15 -0700, Jakub Kicinski wrote: > > On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > > > From: Maxim Mikityanskiy > > > > > > The current ARFS code relies on certain fields to be set in the SKB > > > (

Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-09 Thread Saeed Mahameed
On Thu, 2019-08-08 at 18:15 -0700, Jakub Kicinski wrote: > On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > > From: Maxim Mikityanskiy > > > > The current ARFS code relies on certain fields to be set in the SKB > > (e.g. transport_header) and extracts IP addresses and ports by > > custo

Re: [net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2019 20:22:00 +, Saeed Mahameed wrote: > From: Maxim Mikityanskiy > > The current ARFS code relies on certain fields to be set in the SKB > (e.g. transport_header) and extracts IP addresses and ports by custom > code that parses the packet. The necessary SKB fields, however, are

[net 01/12] net/mlx5e: Use flow keys dissector to parse packets for ARFS

2019-08-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy The current ARFS code relies on certain fields to be set in the SKB (e.g. transport_header) and extracts IP addresses and ports by custom code that parses the packet. The necessary SKB fields, however, are not always set at that point, which leads to an out-of-bounds acce