Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Andy Shevchenko
On Mon, Jul 27, 2020 at 5:11 PM Jiri Pirko wrote: > Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevche...@gmail.com wrote: > >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan > >wrote: ... > >> +err_prestera_dev_register: > >> + free_irq(pci_irq_vector(pdev, 0), fw); > >> +err_request_irq: >

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Jiri Pirko
Mon, Jul 27, 2020 at 03:29:17PM CEST, andy.shevche...@gmail.com wrote: >On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan wrote: [...] > >> + pci_set_drvdata(pdev, fw); >> + >> + err = prestera_fw_init(fw); >> + if (err) >> + goto err_prestera_fw_init; >> + >> +

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Andy Shevchenko
On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan wrote: > > Add PCI interface driver for Prestera Switch ASICs family devices, which > provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > > The firmware

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Jiri Pirko
Mon, Jul 27, 2020 at 02:35:53PM CEST, vadym.koc...@plvision.eu wrote: >Hi Jiri, > >On Mon, Jul 27, 2020 at 02:32:05PM +0200, Jiri Pirko wrote: >> Mon, Jul 27, 2020 at 02:22:38PM CEST, vadym.koc...@plvision.eu wrote: >> >Add PCI interface driver for Prestera Switch ASICs family devices, which >> >pr

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Vadym Kochan
Hi Jiri, On Mon, Jul 27, 2020 at 02:32:05PM +0200, Jiri Pirko wrote: > Mon, Jul 27, 2020 at 02:22:38PM CEST, vadym.koc...@plvision.eu wrote: > >Add PCI interface driver for Prestera Switch ASICs family devices, which > >provides: > > > >- Firmware loading mechanism > >- Requests & events h

Re: [net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Jiri Pirko
Mon, Jul 27, 2020 at 02:22:38PM CEST, vadym.koc...@plvision.eu wrote: >Add PCI interface driver for Prestera Switch ASICs family devices, which >provides: > >- Firmware loading mechanism >- Requests & events handling to/from the firmware >- Access to the firmware on the bus level > >The

[net-next v4 2/6] net: marvell: prestera: Add PCI interface support

2020-07-27 Thread Vadym Kochan
Add PCI interface driver for Prestera Switch ASICs family devices, which provides: - Firmware loading mechanism - Requests & events handling to/from the firmware - Access to the firmware on the bus level The firmware has to be loaded each time the device is reset. The driver is loadin