Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-10 Thread Jacob Keller
On 9/10/2020 2:23 PM, Jakub Kicinski wrote: > On Thu, 10 Sep 2020 13:59:07 -0700 Jacob Keller wrote: >> On 9/9/2020 5:55 PM, Jakub Kicinski wrote: >>> On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: The devlink core recently gained support for checking whether the driver suppo

Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 13:59:07 -0700 Jacob Keller wrote: > On 9/9/2020 5:55 PM, Jakub Kicinski wrote: > > On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: > >> The devlink core recently gained support for checking whether the driver > >> supports a flash_update parameter, via `supported_flash

Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-10 Thread Jacob Keller
On 9/9/2020 5:55 PM, Jakub Kicinski wrote: > On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: >> The devlink core recently gained support for checking whether the driver >> supports a flash_update parameter, via `supported_flash_update_params`. >> However, parameters are specified as funct

Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: > The devlink core recently gained support for checking whether the driver > supports a flash_update parameter, via `supported_flash_update_params`. > However, parameters are specified as function arguments. Adding a new > parameter still requi

[net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-09 Thread Jacob Keller
The devlink core recently gained support for checking whether the driver supports a flash_update parameter, via `supported_flash_update_params`. However, parameters are specified as function arguments. Adding a new parameter still requires modifying the signature of the .flash_update callback in al