Re: [net-next v3 05/15] ice: create flow profile

2020-12-09 Thread Nguyen, Anthony L
On Tue, 2020-12-08 at 14:22 -0800, Alexander Duyck wrote: > On Tue, Dec 8, 2020 at 2:01 PM Nguyen, Anthony L > wrote: > > > > On Tue, 2020-12-08 at 11:00 -0800, Alexander Duyck wrote: > > > On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L > > > wrote: > > > > > > > > On Mon, 2020-11-23 at 17:11

Re: [net-next v3 05/15] ice: create flow profile

2020-12-08 Thread Alexander Duyck
On Tue, Dec 8, 2020 at 2:01 PM Nguyen, Anthony L wrote: > > On Tue, 2020-12-08 at 11:00 -0800, Alexander Duyck wrote: > > On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L > > wrote: > > > > > > On Mon, 2020-11-23 at 17:11 -0800, Alexander Duyck wrote: > > > > On Mon, Nov 23, 2020 at 3:21 PM Jesse

Re: [net-next v3 05/15] ice: create flow profile

2020-12-08 Thread Nguyen, Anthony L
On Tue, 2020-12-08 at 11:00 -0800, Alexander Duyck wrote: > On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L > wrote: > > > > On Mon, 2020-11-23 at 17:11 -0800, Alexander Duyck wrote: > > > On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg > > > wrote: > > > > > > > > Alexander Duyck wrote: > >

Re: [net-next v3 05/15] ice: create flow profile

2020-12-08 Thread Alexander Duyck
On Tue, Dec 8, 2020 at 8:58 AM Nguyen, Anthony L wrote: > > On Mon, 2020-11-23 at 17:11 -0800, Alexander Duyck wrote: > > On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg > > wrote: > > > > > > Alexander Duyck wrote: > > > > > > > > > I'm not sure this logic is correct. Can the flow director > >

Re: [net-next v3 05/15] ice: create flow profile

2020-12-08 Thread Nguyen, Anthony L
On Mon, 2020-11-23 at 17:11 -0800, Alexander Duyck wrote: > On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg > wrote: > > > > Alexander Duyck wrote: > > > > > > > I'm not sure this logic is correct. Can the flow director > > > > > rules > > > > > handle > > > > > a field that is removed? Last I

Re: [net-next v3 05/15] ice: create flow profile

2020-11-23 Thread Alexander Duyck
On Mon, Nov 23, 2020 at 3:21 PM Jesse Brandeburg wrote: > > Alexander Duyck wrote: > > > > > I'm not sure this logic is correct. Can the flow director rules > > > > handle > > > > a field that is removed? Last I knew it couldn't. If that is the case > > > > you should be using ACL for any case in

Re: [net-next v3 05/15] ice: create flow profile

2020-11-23 Thread Jesse Brandeburg
Alexander Duyck wrote: > > > I'm not sure this logic is correct. Can the flow director rules > > > handle > > > a field that is removed? Last I knew it couldn't. If that is the case > > > you should be using ACL for any case in which a full mask is not > > > provided. So in your tests below you co

Re: [net-next v3 05/15] ice: create flow profile

2020-11-20 Thread Alexander Duyck
On Fri, Nov 20, 2020 at 4:42 PM Nguyen, Anthony L wrote: > > On Fri, 2020-11-13 at 15:56 -0800, Alexander Duyck wrote: > > On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen < > > anthony.l.ngu...@intel.com> wrote: > > > > > > From: Real Valiquette > > > > > > Implement the initial steps for creating an

Re: [net-next v3 05/15] ice: create flow profile

2020-11-20 Thread Nguyen, Anthony L
On Fri, 2020-11-13 at 15:56 -0800, Alexander Duyck wrote: > On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen < > anthony.l.ngu...@intel.com> wrote: > > > > From: Real Valiquette > > > > Implement the initial steps for creating an ACL filter to support > > ntuple > > masks. Create a flow profile based

Re: [net-next v3 05/15] ice: create flow profile

2020-11-13 Thread Alexander Duyck
On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen wrote: > > From: Real Valiquette > > Implement the initial steps for creating an ACL filter to support ntuple > masks. Create a flow profile based on a given mask rule and program it to > the hardware. Though the profile is written to hardware, no actio

[net-next v3 05/15] ice: create flow profile

2020-11-13 Thread Tony Nguyen
From: Real Valiquette Implement the initial steps for creating an ACL filter to support ntuple masks. Create a flow profile based on a given mask rule and program it to the hardware. Though the profile is written to hardware, no actions are associated with the profile yet. Co-developed-by: Chinh