Re: [net-next v2 2/5] devlink: introduce flash update overwrite mask

2020-08-03 Thread Jacob Keller
On 8/3/2020 8:38 AM, Jiri Pirko wrote: > Sat, Aug 01, 2020 at 02:21:56AM CEST, jacob.e.kel...@intel.com wrote: > > [...] > >> +nla_mask = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK]; >> +if (nla_mask) { >> +if (!(supported_params & >> DEVLINK_SUPPORT_FLASH_UPDATE

Re: [net-next v2 2/5] devlink: introduce flash update overwrite mask

2020-08-03 Thread Jacob Keller
On 8/3/2020 8:38 AM, Jiri Pirko wrote: > Sat, Aug 01, 2020 at 02:21:56AM CEST, jacob.e.kel...@intel.com wrote: > > [...] > >> +nla_mask = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK]; >> +if (nla_mask) { >> +if (!(supported_params & >> DEVLINK_SUPPORT_FLASH_UPDATE

Re: [net-next v2 2/5] devlink: introduce flash update overwrite mask

2020-08-03 Thread Jiri Pirko
Sat, Aug 01, 2020 at 02:21:56AM CEST, jacob.e.kel...@intel.com wrote: [...] >+ nla_mask = info->attrs[DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK]; >+ if (nla_mask) { >+ if (!(supported_params & >DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK)) { >+ NL_SET_E

[net-next v2 2/5] devlink: introduce flash update overwrite mask

2020-07-31 Thread Jacob Keller
Sections of device flash may contain settings or device identifying information. When performing a flash update, it is generally expected that these settings and identifiers are not overwritten. Sometimes it is useful to be able to overwrite these fields when performing a flash update. To support