Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 15:03:40 -0800 Arjun Roy wrote: > But, if it's an IN or IN-OUT field, it seems like mandating that the > application set it to 0 could break the case where a future > application sets it to some non-zero value and runs on an older > kernel. That usually works fine in practice, 0

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-02-01 Thread Leon Romanovsky
On Mon, Feb 01, 2021 at 06:20:23PM -0800, Arjun Roy wrote: > On Mon, Feb 1, 2021 at 6:06 PM David Ahern wrote: > > > > On 1/24/21 11:15 PM, Leon Romanovsky wrote: > > > On Fri, Jan 22, 2021 at 10:55:45PM -0700, David Ahern wrote: > > >> On 1/22/21 9:07 PM, Jakub Kicinski wrote: > > >>> On Wed, 20

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-02-01 Thread David Ahern
On 1/24/21 11:15 PM, Leon Romanovsky wrote: > On Fri, Jan 22, 2021 at 10:55:45PM -0700, David Ahern wrote: >> On 1/22/21 9:07 PM, Jakub Kicinski wrote: >>> On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote: diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h index 768e93bd5b

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-01-24 Thread Leon Romanovsky
On Fri, Jan 22, 2021 at 10:55:45PM -0700, David Ahern wrote: > On 1/22/21 9:07 PM, Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote: > >> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > >> index 768e93bd5b51..b216270105af 100644 > >> --- a/include/uapi

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-01-22 Thread David Ahern
On 1/22/21 9:07 PM, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote: >> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h >> index 768e93bd5b51..b216270105af 100644 >> --- a/include/uapi/linux/tcp.h >> +++ b/include/uapi/linux/tcp.h >> @@ -353,5 +353,9 @@ s

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-01-22 Thread Jakub Kicinski
On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote: > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > index 768e93bd5b51..b216270105af 100644 > --- a/include/uapi/linux/tcp.h > +++ b/include/uapi/linux/tcp.h > @@ -353,5 +353,9 @@ struct tcp_zerocopy_receive { > __u64 copybu

[net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-01-20 Thread Arjun Roy
From: Arjun Roy tcp_recvmsg() uses the CMSG mechanism to receive control information like packet receive timestamps. This patch adds CMSG fields to struct tcp_zerocopy_receive, and provides receive timestamps if available to the user. Signed-off-by: Arjun Roy --- include/uapi/linux/tcp.h | 4