RE: [net-next v2 2/2] net: reject ptp requests with unsupported flags

2019-09-26 Thread Keller, Jacob E
Jeffrey T ; Felipe Balbi > ; David S . Miller ; Hall, > Christopher S > Subject: Re: [net-next v2 2/2] net: reject ptp requests with unsupported flags > > On Wed, Sep 25, 2019 at 07:28:20PM -0700, Jacob Keller wrote: > > This patch may not be correct for individual drivers, especi

RE: [net-next v2 2/2] net: reject ptp requests with unsupported flags

2019-09-26 Thread Keller, Jacob E
Jeffrey T ; Felipe Balbi > ; David S . Miller ; Hall, > Christopher S > Subject: Re: [net-next v2 2/2] net: reject ptp requests with unsupported flags > > On Wed, Sep 25, 2019 at 07:28:20PM -0700, Jacob Keller wrote: > > This patch may not be correct for individual drivers, especi

Re: [net-next v2 2/2] net: reject ptp requests with unsupported flags

2019-09-25 Thread Richard Cochran
On Wed, Sep 25, 2019 at 07:28:20PM -0700, Jacob Keller wrote: > This patch may not be correct for individual drivers, especially > regarding the rising vs falling edge flags. I interpreted the default > behavior to be to timestamp the rising edge of a pin transition. So I think this patch goes too

[net-next v2 2/2] net: reject ptp requests with unsupported flags

2019-09-25 Thread Jacob Keller
Fix all of the drivers which implement support for the periodic output or external timestamp requests to reject unsupported flags. This is important for forward compatibility: if a new flag is introduced, the driver should reject requests to enable the flag until it has been modified to actually s