Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-11 Thread Saeed Mahameed
On Wed, 2020-09-09 at 14:34 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 9 Sep 2020 19:22:02 + > > > Maxim really tried here to avoid this without huge performance > > degradation (~6.4% reduce in packet rate), due to the refactoring > > patches gcc yields non optimal code,

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-09 Thread David Miller
From: Saeed Mahameed Date: Wed, 9 Sep 2020 19:22:02 + > Maxim really tried here to avoid this without huge performance > degradation (~6.4% reduce in packet rate), due to the refactoring > patches gcc yields non optimal code, as we explained in the commit > messages and cover-letter > > Our

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-09 Thread Saeed Mahameed
On Wed, 2020-09-09 at 12:28 -0700, Jakub Kicinski wrote: > On Wed, 9 Sep 2020 19:22:02 + Saeed Mahameed wrote: > > On Tue, 2020-09-08 at 20:29 -0700, David Miller wrote: > > > From: David Miller > > > Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT) > > > > > > > From: Saeed Mahameed > > > > Da

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 19:22:02 + Saeed Mahameed wrote: > On Tue, 2020-09-08 at 20:29 -0700, David Miller wrote: > > From: David Miller > > Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT) > > > > > From: Saeed Mahameed > > > Date: Tue, 8 Sep 2020 18:27:48 -0700 > > > > > > > --- a/drivers/net/e

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-09 Thread Saeed Mahameed
On Tue, 2020-09-08 at 20:29 -0700, David Miller wrote: > From: David Miller > Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT) > > > From: Saeed Mahameed > > Date: Tue, 8 Sep 2020 18:27:48 -0700 > > > > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > > > +++ b/drivers/net/ethernet/mellanox

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread David Miller
From: David Miller Date: Tue, 08 Sep 2020 20:28:36 -0700 (PDT) > From: Saeed Mahameed > Date: Tue, 8 Sep 2020 18:27:48 -0700 > >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c >> @@ -232,6 +232,29 @@ mlx5e_txwqe_build_dsegs(struct

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread David Miller
From: Saeed Mahameed Date: Tue, 8 Sep 2020 18:27:48 -0700 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > @@ -232,6 +232,29 @@ mlx5e_txwqe_build_dsegs(struct mlx5e_txqsq *sq, struct > sk_buff *skb, > return -ENOMEM; > } >

[net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-08 Thread Saeed Mahameed
From: Maxim Mikityanskiy Move mlx5e_tx_wqe_inline_mode from en/txrx.h to en_tx.c as it's only used there. Signed-off-by: Maxim Mikityanskiy Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 23 --- .../net/ethernet/mel