Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-10 Thread Jakub Kicinski
On Wed, 10 Feb 2021 13:25:05 +0200 Vlad Buslov wrote: > On Tue 09 Feb 2021 at 21:50, Jakub Kicinski wrote: > > On Tue, 9 Feb 2021 21:17:11 +0200 Vlad Buslov wrote: > >> 4. Decapsulated payload appears on namespaced VF with IP address > >> 5.5.5.5: > >> > >> $ sudo ip netns exec ns0 tcpdump -ni

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-10 Thread Vlad Buslov
On Wed 10 Feb 2021 at 15:56, Marcelo Ricardo Leitner wrote: > On Tue, Feb 09, 2021 at 06:10:59PM +0200, Or Gerlitz wrote: >> On Tue, Feb 9, 2021 at 4:26 PM Vlad Buslov wrote: >> > On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote: >> > > On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote: >>

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-10 Thread Marcelo Ricardo Leitner
On Tue, Feb 09, 2021 at 06:10:59PM +0200, Or Gerlitz wrote: > On Tue, Feb 9, 2021 at 4:26 PM Vlad Buslov wrote: > > On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote: > > > On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote: > > > >> > These operations imply that 7.7.7.5 is configured on some i

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-10 Thread Vlad Buslov
On Tue 09 Feb 2021 at 21:50, Jakub Kicinski wrote: > On Tue, 9 Feb 2021 21:17:11 +0200 Vlad Buslov wrote: >> 4. Decapsulated payload appears on namespaced VF with IP address >> 5.5.5.5: >> >> $ sudo ip netns exec ns0 tcpdump -ni enp8s0f0v1 -vvv -c 3 > > So there are two VFs? Hm, completely mis

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 21:17:11 +0200 Vlad Buslov wrote: > 4. Decapsulated payload appears on namespaced VF with IP address > 5.5.5.5: > > $ sudo ip netns exec ns0 tcpdump -ni enp8s0f0v1 -vvv -c 3 So there are two VFs? Hm, completely missed that. Could you *please* provide an ascii diagram for the e

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-09 Thread Vlad Buslov
On Tue 09 Feb 2021 at 20:05, Jakub Kicinski wrote: > On Tue, 9 Feb 2021 16:22:26 +0200 Vlad Buslov wrote: >> No, tunnel IP is configured on VF. That particular VF is in host >> namespace. When mlx5 resolves tunneling the code checks if tunnel >> endpoint IP address is on such mlx5 VF, since the

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-09 Thread Jakub Kicinski
On Tue, 9 Feb 2021 16:22:26 +0200 Vlad Buslov wrote: > No, tunnel IP is configured on VF. That particular VF is in host > namespace. When mlx5 resolves tunneling the code checks if tunnel > endpoint IP address is on such mlx5 VF, since the VF is in same > namespace as eswitch manager (e.g. on host)

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 4:26 PM Vlad Buslov wrote: > On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote: > >> > These operations imply that 7.7.7.5 is configured on some interface on > >> > the host. Most likely the VF representor itself, as

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-09 Thread Vlad Buslov
On Mon 08 Feb 2021 at 22:22, Jakub Kicinski wrote: > On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote: >> > These operations imply that 7.7.7.5 is configured on some interface on >> > the host. Most likely the VF representor itself, as that aids with ARP >> > resolution. Is that so? >> >> Hi M

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 5 Feb 2021 21:02:24 -0800 you wrote: > From: Mark Bloch > > Setting the source port requires only the E-Switch and vport number. > Refactor the function to get those parameters instead of passing the full > attr

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 10:21:21 +0200 Vlad Buslov wrote: > > These operations imply that 7.7.7.5 is configured on some interface on > > the host. Most likely the VF representor itself, as that aids with ARP > > resolution. Is that so? > > Hi Marcelo, > > The tunnel endpoint IP address is configured o

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-08 Thread Marcelo Ricardo Leitner
On Mon, Feb 08, 2021 at 03:31:50PM +0200, Vlad Buslov wrote: > > On Mon 08 Feb 2021 at 15:25, Marcelo Ricardo Leitner > wrote: > > On Mon, Feb 08, 2021 at 10:21:21AM +0200, Vlad Buslov wrote: > >> > >> On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner > >> wrote: > >> > Hi, > >> > > >> > I

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-08 Thread Vlad Buslov
On Mon 08 Feb 2021 at 15:25, Marcelo Ricardo Leitner wrote: > On Mon, Feb 08, 2021 at 10:21:21AM +0200, Vlad Buslov wrote: >> >> On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner >> wrote: >> > Hi, >> > >> > I didn't receive the cover letter, so I'm replying on this one. :-) >> > >> > Thi

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-08 Thread Marcelo Ricardo Leitner
On Mon, Feb 08, 2021 at 10:21:21AM +0200, Vlad Buslov wrote: > > On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner > wrote: > > Hi, > > > > I didn't receive the cover letter, so I'm replying on this one. :-) > > > > This is nice. One thing is not clear to me yet. From the samples on > > the c

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-08 Thread Vlad Buslov
On Sat 06 Feb 2021 at 20:13, Marcelo Ricardo Leitner wrote: > Hi, > > I didn't receive the cover letter, so I'm replying on this one. :-) > > This is nice. One thing is not clear to me yet. From the samples on > the cover letter: > > $ tc -s filter show dev enp8s0f0_1 ingress > filter protocol

Re: [net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-06 Thread Marcelo Ricardo Leitner
Hi, I didn't receive the cover letter, so I'm replying on this one. :-) This is nice. One thing is not clear to me yet. From the samples on the cover letter: $ tc -s filter show dev enp8s0f0_1 ingress filter protocol ip pref 4 flower chain 0 filter protocol ip pref 4 flower chain 0 handle 0x1

[net-next V2 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-05 Thread Saeed Mahameed
From: Mark Bloch Setting the source port requires only the E-Switch and vport number. Refactor the function to get those parameters instead of passing the full attribute. Signed-off-by: Mark Bloch Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/eswitch_of