Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-07 Thread Jiri Pirko
Fri, Jan 06, 2017 at 08:08:58PM CET, kubak...@wp.pl wrote: >On Fri, 6 Jan 2017 18:30:35 +0100, Jiri Pirko wrote: >> >> > + skb_dst_drop(skb); >> >> > + dst_hold(&priv->vfpr_dst->dst); >> >> > + skb_dst_set(skb, &priv->vfpr_dst->dst); >> >> > + skb->dev = vsi->netdev; >> >>

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-06 Thread Jakub Kicinski
On Fri, 6 Jan 2017 18:30:35 +0100, Jiri Pirko wrote: > >> > +skb_dst_drop(skb); > >> > +dst_hold(&priv->vfpr_dst->dst); > >> > +skb_dst_set(skb, &priv->vfpr_dst->dst); > >> > +skb->dev = vsi->netdev; > >> This dst dance seems a bit odd to me. Why don't you just cal

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-06 Thread Jiri Pirko
Fri, Jan 06, 2017 at 01:27:13AM CET, sridhar.samudr...@intel.com wrote: > > >On 1/5/2017 4:56 AM, Jiri Pirko wrote: >> Tue, Jan 03, 2017 at 07:07:53PM CET, sridhar.samudr...@intel.com wrote: >> > In switchdev mode, broadcast filter is not enabled on VFs. The broadcasts >> > and >> > unknown frames

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Samudrala, Sridhar
On 1/5/2017 4:56 AM, Jiri Pirko wrote: Tue, Jan 03, 2017 at 07:07:53PM CET, sridhar.samudr...@intel.com wrote: In switchdev mode, broadcast filter is not enabled on VFs. The broadcasts and unknown frames from VFs are received by the PF and passed to corresponding VF port representator netdev.

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Jakub Kicinski
On Thu, Jan 5, 2017 at 12:08 PM, Or Gerlitz wrote: > On Tue, Jan 3, 2017 at 8:07 PM, Sridhar Samudrala > wrote: >> A host based switching entity like a linux bridge or OVS redirects these >> frames >> to the right VFs via VFPR netdevs. Any frames sent via VFPR netdevs are sent >> as >> directed

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Jiri Pirko
Tue, Jan 03, 2017 at 07:07:53PM CET, sridhar.samudr...@intel.com wrote: >In switchdev mode, broadcast filter is not enabled on VFs. The broadcasts and >unknown frames from VFs are received by the PF and passed to corresponding VF >port representator netdev. >A host based switching entity like a lin

Re: [net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-05 Thread Or Gerlitz
On Tue, Jan 3, 2017 at 8:07 PM, Sridhar Samudrala wrote: > A host based switching entity like a linux bridge or OVS redirects these > frames > to the right VFs via VFPR netdevs. Any frames sent via VFPR netdevs are sent > as > directed transmits to the corresponding VFs. To enable directed trans

[net-next PATCH v2 5/6] i40e: Add TX and RX support in switchdev mode.

2017-01-03 Thread Sridhar Samudrala
In switchdev mode, broadcast filter is not enabled on VFs. The broadcasts and unknown frames from VFs are received by the PF and passed to corresponding VF port representator netdev. A host based switching entity like a linux bridge or OVS redirects these frames to the right VFs via VFPR netdevs. A