Re: [net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc

2015-08-26 Thread Phil Sutter
Hi Jesper, On Sun, Aug 23, 2015 at 08:53:57PM +0200, Jesper Dangaard Brouer wrote: > On Sun, 23 Aug 2015 20:44:42 +0200 > Jesper Dangaard Brouer wrote: > > > On Sat, 22 Aug 2015 02:20:56 +0200 > > Phil Sutter wrote: > > > > > When removing the root qdisc, the interface should fall back to noqu

Re: [net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc

2015-08-23 Thread Jesper Dangaard Brouer
On Sun, 23 Aug 2015 20:44:42 +0200 Jesper Dangaard Brouer wrote: > On Sat, 22 Aug 2015 02:20:56 +0200 > Phil Sutter wrote: > > > When removing the root qdisc, the interface should fall back to noqueue > > as the 'real' minimal qdisc instead of the default one. > > I worry this behavior could

Re: [net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc

2015-08-23 Thread Jesper Dangaard Brouer
On Sat, 22 Aug 2015 02:20:56 +0200 Phil Sutter wrote: > When removing the root qdisc, the interface should fall back to noqueue > as the 'real' minimal qdisc instead of the default one. I worry this behavior could break existing scripts. I prefer the idea of allowing tc command to assign noque

[net-next PATCH v2 3/3] net: sched: fall back to noqueue when removing root qdisc

2015-08-21 Thread Phil Sutter
When removing the root qdisc, the interface should fall back to noqueue as the 'real' minimal qdisc instead of the default one. Therefore dev_graft_qdisc() has to be adjusted to assign noqueue if NULL was passed as new qdisc, and qdisc_graft() needs to assign noqueue to dev->qdisc instead of noop t