Re: [net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported

2016-05-02 Thread Or Gerlitz
On Mon, May 2, 2016 at 5:16 AM, Alexander Duyck wrote: > On Sun, May 1, 2016 at 1:30 PM, Or Gerlitz wrote: >> On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: >>> In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum >>> offload for tunnels. >> >> Alex, >> >> To clarif

Re: [net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported

2016-05-01 Thread Alexander Duyck
On Sun, May 1, 2016 at 1:30 PM, Or Gerlitz wrote: > On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: >> In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum >> offload for tunnels. > > Alex, > > To clarify, when you say "not support IPv6 checksum for tunnels", you > re

Re: [net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported

2016-05-01 Thread Or Gerlitz
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum > offload for tunnels. Alex, To clarify, when you say "not support IPv6 checksum for tunnels", you refer to the offloading of the outer or inner checksum? Still (m

[net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported

2016-04-29 Thread Alexander Duyck
In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum offload for tunnels. With this being the case we should disable GSO in addition to the checksum offload features when we find that a device cannot perform a checksum on a given packet type. Signed-off-by: Alexander Duyck -