Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-28 Thread Sebastian Frias
On 25/11/16 18:44, Florian Fainelli wrote: > On 11/25/2016 03:13 AM, Sebastian Frias wrote: >> On 24/11/16 19:55, Florian Fainelli wrote: >>> Correct, the meaning of PHY_INTERFACE_MODE should be from the >>> perspective of the PHY device: >>> >>> - PHY_INTERFACE_MODE_RGMII_TXID means that the PHY

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-25 Thread Florian Fainelli
On 11/25/2016 03:13 AM, Sebastian Frias wrote: > On 24/11/16 19:55, Florian Fainelli wrote: >> Le 24/11/2016 à 09:05, Martin Blumenstingl a écrit : >>> On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet wrote: On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: > Currently the dwmac

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-25 Thread Måns Rullgård
Sebastian Frias writes: > On 24/11/16 19:55, Florian Fainelli wrote: >> Le 24/11/2016 à 09:05, Martin Blumenstingl a écrit : >>> Based on what I found it seems that rgmii-id, rgmii-txid and >>> rgmii-rxid are supposed to be handled by the PHY. >> >> Correct, the meaning of PHY_INTERFACE_MODE sho

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-25 Thread Sebastian Frias
On 24/11/16 19:55, Florian Fainelli wrote: > Le 24/11/2016 à 09:05, Martin Blumenstingl a écrit : >> On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet wrote: >>> On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-25 Thread Jerome Brunet
On Thu, 2016-11-24 at 18:05 +0100, Martin Blumenstingl wrote: > On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet > wrote: > > > > On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: > > > > > > Currently the dwmac-meson8b stmmac glue driver uses a hardcoded > > > 1/4 > > > cycle TX clock

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-25 Thread Giuseppe CAVALLARO
On 11/24/2016 5:08 PM, Jerome Brunet wrote: On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but th

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Martin Blumenstingl
On Thu, Nov 24, 2016 at 7:55 PM, Florian Fainelli wrote: > Le 24/11/2016 à 09:05, Martin Blumenstingl a écrit : >> On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet wrote: >>> On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: Currently the dwmac-meson8b stmmac glue driver uses a har

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Florian Fainelli
Le 24/11/2016 à 09:05, Martin Blumenstingl a écrit : > On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet wrote: >> On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: >>> Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 >>> cycle TX clock delay. This seems to work fine fo

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Martin Blumenstingl
On Thu, Nov 24, 2016 at 4:56 PM, Jerome Brunet wrote: > On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: >> Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 >> cycle TX clock delay. This seems to work fine for many boards (for >> example Odroid-C2 or Amlogic's refer

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Jerome Brunet
On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: > Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 > cycle TX clock delay. This seems to work fine for many boards (for > example Odroid-C2 or Amlogic's reference boards) but there are some > others where TX traffic is

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Jerome Brunet
On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: > Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 > cycle TX clock delay. This seems to work fine for many boards (for > example Odroid-C2 or Amlogic's reference boards) but there are some > others where TX traffic is

[net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2016-11-24 Thread Martin Blumenstingl
Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but there are some others where TX traffic is simply broken. There are probably multiple reasons why it's working o