On 16-04-21 05:41 PM, Jamal Hadi Salim wrote:
On 16-04-21 05:36 PM, Stephen Hemminger wrote:
On Thu, 21 Apr 2016 21:27:39 +
Jamal Hadi Salim wrote:
I use checkpatch from kernel source to check iproute code now.
ah. It was wrong in this specific case.
In any case I just resent the patc
On 16-04-21 05:36 PM, Stephen Hemminger wrote:
On Thu, 21 Apr 2016 21:27:39 +
Jamal Hadi Salim wrote:
I use checkpatch from kernel source to check iproute code now.
ah. It was wrong in this specific case.
In any case I just resent the patch with the fixes.
cheers,
jamal
On Thu, 21 Apr 2016 21:27:39 +
Jamal Hadi Salim wrote:
> > The code has also gotten deeply intended creating lots of lines that are
> > too long.
> >
>
> Is this you or the script saying the above? How is the conclusion that
> we have deep indentation come about?
> I checked there are som
Sorry dropped the ball on this..
On 16-03-14 02:26 AM, Stephen Hemminger wrote:
On Wed, 9 Mar 2016 07:04:36 -0500
Jamal Hadi Salim wrote:
This code has diverged way from the general rule that ip utilities display
format should match the command format. For example the properties shown
on "
On Wed, 9 Mar 2016 07:04:36 -0500
Jamal Hadi Salim wrote:
> + fprintf(f, "\t Metadata: ");
> +
> + if (metalist[IFE_META_SKBMARK]) {
> + len = RTA_PAYLOAD(metalist[IFE_META_SKBMARK]);
> + if (len) {
> + _
On Thu, Mar 10, 2016 at 07:42:29AM -0500, Jamal Hadi Salim wrote:
> On 16-03-09 08:12 AM, Phil Sutter wrote:
> > On Wed, Mar 09, 2016 at 07:04:36AM -0500, Jamal Hadi Salim wrote:
> >> +static void ife_explain(void)
> >> +{
> >> + fprintf(stderr,
> >> + "Usage:... ife {decode|encode} {ALLO
On 16-03-09 08:12 AM, Phil Sutter wrote:
On Wed, Mar 09, 2016 at 07:04:36AM -0500, Jamal Hadi Salim wrote:
+static void ife_explain(void)
+{
+ fprintf(stderr,
+ "Usage:... ife {decode|encode} {ALLOW|USE} [dst DMAC] [src SMAC]
[type TYPE] [CONTROL] [index INDEX]\n");
I'm ju
On Wed, Mar 09, 2016 at 07:04:36AM -0500, Jamal Hadi Salim wrote:
> +static void ife_explain(void)
> +{
> + fprintf(stderr,
> + "Usage:... ife {decode|encode} {ALLOW|USE} [dst DMAC] [src
> SMAC] [type TYPE] [CONTROL] [index INDEX]\n");
I'm just nitpicking here, but this syntax imp
From: Jamal Hadi Salim
This action allows for a sending side to encapsulate arbitrary metadata
which is decapsulated by the receiving end.
The sender runs in encoding mode and the receiver in decode mode.
Both sender and receiver must specify the same ethertype.
At some point we hope to have a re
